op-node: Add tests for ip and peer ban books

op-node/p2p/gating/expiry.go

 package gating
 
 import (
+	"errors"
 	"time"
 
 	"github.com/libp2p/go-libp2p/core/network"
@@ -47,7 +48,7 @@ func AddBanExpiry(gater BlockingConnectionGater, store ExpiryStore, log log.Logg
 func (g *ExpiryConnectionGater) peerBanExpiryCheck(p peer.ID) (allow bool) {
 	// if the peer is blocked, check if it's time to unblock
 	expiry, err := g.store.GetPeerBanExpiration(p)
-	if err == store.UnknownBanErr {
+	if errors.Is(err, store.UnknownBanErr) {
 		return true // peer is allowed if it has not been banned
 	}
 	if err != nil {
@@ -74,7 +75,7 @@ func (g *ExpiryConnectionGater) addrBanExpiryCheck(ma multiaddr.Multiaddr) (allo
 	}
 	// if just the IP is blocked, check if it's time to unblock
 	expiry, err := g.store.GetIPBanExpiration(ip)
-	if err == store.UnknownBanErr {
+	if errors.Is(err, store.UnknownBanErr) {
 		return true // IP is allowed if it has not been banned
 	}
 	if err != nil {

op-node/p2p/store/ip_ban_book_test.go

+package store
+
+import (
+	"context"
+	"net"
+	"testing"
+	"time"
+
+	"github.com/ethereum-optimism/optimism/op-node/testlog"
+	"github.com/ethereum-optimism/optimism/op-service/clock"
+	"github.com/ethereum/go-ethereum/log"
+	ds "github.com/ipfs/go-datastore"
+	"github.com/ipfs/go-datastore/sync"
+	"github.com/stretchr/testify/require"
+)
+
+func TestGetUnknownIPBan(t *testing.T) {
+	book := createMemoryIPBanBook(t)
+	defer book.Close()
+	exp, err := book.GetIPBanExpiration(net.IPv4(1, 2, 3, 4))
+	require.Same(t, UnknownBanErr, err)
+	require.Equal(t, time.Time{}, exp)
+}
+
+func TestRoundTripIPBan(t *testing.T) {
+	book := createMemoryIPBanBook(t)
+	defer book.Close()
+	expiry := time.Unix(2484924, 0)
+	ip := net.IPv4(1, 2, 3, 4)
+	require.NoError(t, book.SetIPBanExpiration(ip, expiry))
+	result, err := book.GetIPBanExpiration(ip)
+	require.NoError(t, err)
+	require.Equal(t, result, expiry)
+}
+
+func createMemoryIPBanBook(t *testing.T) *ipBanBook {
+	store := sync.MutexWrap(ds.NewMapDatastore())
+	logger := testlog.Logger(t, log.LvlInfo)
+	c := clock.NewDeterministicClock(time.UnixMilli(100))
+	book, err := newIPBanBook(context.Background(), logger, c, store)
+	require.NoError(t, err)
+	return book
+}

op-node/p2p/store/peer_ban_book_test.go

+package store
+
+import (
+	"context"
+	"testing"
+	"time"
+
+	"github.com/ethereum-optimism/optimism/op-node/testlog"
+	"github.com/ethereum-optimism/optimism/op-service/clock"
+	"github.com/ethereum/go-ethereum/log"
+	ds "github.com/ipfs/go-datastore"
+	"github.com/ipfs/go-datastore/sync"
+	"github.com/stretchr/testify/require"
+)
+
+func TestGetUnknownPeerBan(t *testing.T) {
+	book := createMemoryPeerBanBook(t)
+	defer book.Close()
+	exp, err := book.GetPeerBanExpiration("a")
+	require.Same(t, UnknownBanErr, err)
+	require.Equal(t, time.Time{}, exp)
+}
+
+func TestRoundTripPeerBan(t *testing.T) {
+	book := createMemoryPeerBanBook(t)
+	defer book.Close()
+	expiry := time.Unix(2484924, 0)
+	require.NoError(t, book.SetPeerBanExpiration("a", expiry))
+	result, err := book.GetPeerBanExpiration("a")
+	require.NoError(t, err)
+	require.Equal(t, result, expiry)
+}
+
+func createMemoryPeerBanBook(t *testing.T) *peerBanBook {
+	store := sync.MutexWrap(ds.NewMapDatastore())
+	logger := testlog.Logger(t, log.LvlInfo)
+	c := clock.NewDeterministicClock(time.UnixMilli(100))
+	book, err := newPeerBanBook(context.Background(), logger, c, store)
+	require.NoError(t, err)
+	return book
+}