Commit 344e0639 authored by protolambda's avatar protolambda

op-node: enable all network options by default

parent f0a81441
...@@ -7,7 +7,6 @@ import ( ...@@ -7,7 +7,6 @@ import (
"time" "time"
"github.com/ethereum-optimism/optimism/op-challenger/config" "github.com/ethereum-optimism/optimism/op-challenger/config"
"github.com/ethereum-optimism/optimism/op-node/chaincfg"
"github.com/ethereum-optimism/optimism/op-service/txmgr" "github.com/ethereum-optimism/optimism/op-service/txmgr"
"github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/log" "github.com/ethereum/go-ethereum/log"
...@@ -17,8 +16,8 @@ import ( ...@@ -17,8 +16,8 @@ import (
var ( var (
l1EthRpc = "http://example.com:8545" l1EthRpc = "http://example.com:8545"
gameFactoryAddressValue = "0xbb00000000000000000000000000000000000000" gameFactoryAddressValue = "0xbb00000000000000000000000000000000000000"
cannonNetwork = chaincfg.AvailableNetworks()[0] cannonNetwork = "op-mainnet"
otherCannonNetwork = chaincfg.AvailableNetworks()[1] otherCannonNetwork = "op-goerli"
cannonBin = "./bin/cannon" cannonBin = "./bin/cannon"
cannonServer = "./bin/op-program" cannonServer = "./bin/op-program"
cannonPreState = "./pre.json" cannonPreState = "./pre.json"
......
...@@ -33,14 +33,7 @@ var L2ChainIDToNetworkDisplayName = func() map[string]string { ...@@ -33,14 +33,7 @@ var L2ChainIDToNetworkDisplayName = func() map[string]string {
}() }()
// AvailableNetworks returns the selection of network configurations that is available by default. // AvailableNetworks returns the selection of network configurations that is available by default.
// Other configurations that are part of the superchain-registry can be used with the --beta.network flag.
func AvailableNetworks() []string { func AvailableNetworks() []string {
return []string{"op-mainnet", "op-goerli", "op-sepolia"}
}
// BetaAvailableNetworks returns all available network configurations in the superchain-registry.
// This set of configurations is experimental, and may change at any time.
func BetaAvailableNetworks() []string {
var networks []string var networks []string
for _, cfg := range superchain.OPChains { for _, cfg := range superchain.OPChains {
networks = append(networks, cfg.Chain+"-"+cfg.Superchain) networks = append(networks, cfg.Chain+"-"+cfg.Superchain)
...@@ -48,20 +41,6 @@ func BetaAvailableNetworks() []string { ...@@ -48,20 +41,6 @@ func BetaAvailableNetworks() []string {
return networks return networks
} }
func IsAvailableNetwork(name string, beta bool) bool {
name = handleLegacyName(name)
available := AvailableNetworks()
if beta {
available = BetaAvailableNetworks()
}
for _, v := range available {
if v == name {
return true
}
}
return false
}
func handleLegacyName(name string) string { func handleLegacyName(name string) string {
switch name { switch name {
case "goerli": case "goerli":
......
...@@ -27,8 +27,6 @@ func TestGetRollupConfig(t *testing.T) { ...@@ -27,8 +27,6 @@ func TestGetRollupConfig(t *testing.T) {
} }
for name, expectedCfg := range configsByName { for name, expectedCfg := range configsByName {
require.True(t, IsAvailableNetwork(name, false))
gotCfg, err := GetRollupConfig(name) gotCfg, err := GetRollupConfig(name)
require.NoError(t, err) require.NoError(t, err)
......
...@@ -237,11 +237,10 @@ var ( ...@@ -237,11 +237,10 @@ var (
Value: false, Value: false,
} }
BetaExtraNetworks = &cli.BoolFlag{ BetaExtraNetworks = &cli.BoolFlag{
Name: "beta.extra-networks", Name: "beta.extra-networks",
Usage: fmt.Sprintf("Beta feature: enable selection of a predefined-network from the superchain-registry. "+ Usage: "Legacy flag, ignored, all superchain-registry networks are enabled by default.",
"The superchain-registry is experimental, and the availability of configurations may change."+
"Available networks: %s", strings.Join(chaincfg.BetaAvailableNetworks(), ", ")),
EnvVars: prefixEnvVars("BETA_EXTRA_NETWORKS"), EnvVars: prefixEnvVars("BETA_EXTRA_NETWORKS"),
Hidden: true, // hidden, this is deprecated, the flag is not used anymore.
} }
RollupHalt = &cli.StringFlag{ RollupHalt = &cli.StringFlag{
Name: "rollup.halt", Name: "rollup.halt",
......
...@@ -194,10 +194,6 @@ Startup will proceed to use the network-parameter and ignore the rollup config. ...@@ -194,10 +194,6 @@ Startup will proceed to use the network-parameter and ignore the rollup config.
Conflicting configuration is deprecated, and will stop the op-node from starting in the future. Conflicting configuration is deprecated, and will stop the op-node from starting in the future.
`, "network", network, "rollup_config", rollupConfigPath) `, "network", network, "rollup_config", rollupConfigPath)
} }
// check that the network is available
if !chaincfg.IsAvailableNetwork(network, ctx.Bool(flags.BetaExtraNetworks.Name)) {
return nil, fmt.Errorf("unavailable network: %q", network)
}
config, err := chaincfg.GetRollupConfig(network) config, err := chaincfg.GetRollupConfig(network)
if err != nil { if err != nil {
return nil, err return nil, err
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment