integration-tests: Fix various actor tests (#2517)

Several tests were failing with out of gas errors because they began executing before their
wallets were adequately funded.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

.changeset/twelve-suits-camp.md

+---
+'@eth-optimism/integration-tests': patch
+---
+
+Fix various actor tests

integration-tests/actor-tests/README.md

@@ -49,10 +49,11 @@ actor('Value sender', () => {
 
   setupRun(async () => {
     const wallet = Wallet.createRandom()
-    await env.l2Wallet.sendTransaction({
+    const tx = await env.l2Wallet.sendTransaction({
       to: wallet.address,
       value: utils.parseEther('0.01'),
     })
+    await tx.wait()
     return {
       wallet: wallet.connect(env.l2Wallet.provider),
     }
@@ -61,10 +62,11 @@ actor('Value sender', () => {
   run(async (b, ctx: Context) => {
     const randWallet = Wallet.createRandom().connect(env.l2Wallet.provider)
     await b.bench('send funds', async () => {
-      await ctx.wallet.sendTransaction({
+      const tx = await ctx.wallet.sendTransaction({
         to: randWallet.address,
         value: 0x42,
       })
+      await tx.wait()
     })
     expect(await randWallet.getBalance()).to.deep.equal(BigNumber.from(0x42))
   })
@@ -163,4 +165,4 @@ actor_successful_actor_runs_total{actor_name="value_sender"} 40
 
 # HELP actor_failed_actor_runs_total Count of total failed actor runs.
 # TYPE actor_failed_actor_runs_total counter
-```
\ No newline at end of file
+```

integration-tests/actor-tests/deposits.test.ts

@@ -21,10 +21,11 @@ actor('Funds depositor', () => {
 
   setupRun(async () => {
     const wallet = Wallet.createRandom()
-    await env.l1Wallet.sendTransaction({
+    const tx = await env.l1Wallet.sendTransaction({
       to: wallet.address,
       value: utils.parseEther('0.01'),
     })
+    await tx.wait()
     return {
       l1Wallet: wallet.connect(env.l1Wallet.provider),
       l2Wallet: wallet.connect(env.l2Wallet.provider),
@@ -36,7 +37,7 @@ actor('Funds depositor', () => {
     const balBefore = await l2Wallet.getBalance()
     await b.bench('deposit', async () => {
       await env.waitForXDomainTransaction(
-        env.l1Bridge
+        env.messenger.contracts.l1.L1StandardBridge
           .connect(l1Wallet)
           .depositETH(DEFAULT_TEST_GAS_L2, '0xFFFF', {
             value: 0x42,
@@ -44,8 +45,10 @@ actor('Funds depositor', () => {
           })
       )
     })
-    expect((await l2Wallet.getBalance()).sub(balBefore)).to.deep.equal(
-      BigNumber.from(0x42)
+    // Converting BigNumber to hex string prevents chai from incorrectly considering inherited properties
+    // for strict equality - https://github.com/chaijs/chai/issues/948
+    expect((await l2Wallet.getBalance()).sub(balBefore).toString()).to.deep.equal(
+      BigNumber.from(0x42).toString()
     )
   })
 })

integration-tests/actor-tests/nft.test.ts

@@ -22,10 +22,11 @@ actor('NFT claimer', () => {
 
   setupRun(async () => {
     const wallet = Wallet.createRandom().connect(env.l2Wallet.provider)
-    await env.l2Wallet.sendTransaction({
+    const tx = await env.l2Wallet.sendTransaction({
       to: wallet.address,
       value: utils.parseEther('0.01'),
     })
+    await tx.wait()
     return {
       wallet,
       contract: contract.connect(wallet),

integration-tests/actor-tests/sends.test.ts

@@ -17,10 +17,11 @@ actor('Value sender', () => {
 
   setupRun(async () => {
     const wallet = Wallet.createRandom()
-    await env.l2Wallet.sendTransaction({
+    const tx = await env.l2Wallet.sendTransaction({
       to: wallet.address,
       value: utils.parseEther('0.01'),
     })
+    await tx.wait()
     return {
       wallet: wallet.connect(env.l2Wallet.provider),
     }
@@ -29,10 +30,11 @@ actor('Value sender', () => {
   run(async (b, ctx: Context) => {
     const randWallet = Wallet.createRandom().connect(env.l2Wallet.provider)
     await b.bench('send funds', async () => {
-      await ctx.wallet.sendTransaction({
+      const tx = await ctx.wallet.sendTransaction({
         to: randWallet.address,
         value: 0x42,
       })
+      await tx.wait()
     })
     expect((await randWallet.getBalance()).toString()).to.deep.equal('66')
   })

integration-tests/actor-tests/state-dos.test.ts

@@ -24,10 +24,11 @@ actor('Trie DoS accounts', () => {
 
   setupRun(async () => {
     const wallet = Wallet.createRandom()
-    await env.l2Wallet.sendTransaction({
+    const tx = await env.l2Wallet.sendTransaction({
       to: wallet.address,
       value: utils.parseEther('1'),
     })
+    await tx.wait()
     return {
       wallet: wallet.connect(env.l2Wallet.provider),
     }

integration-tests/actor-tests/uniswap.test.ts

@@ -50,10 +50,11 @@ actor('Uniswap swapper', () => {
   setupRun(async () => {
     const wallet = Wallet.createRandom().connect(env.l2Provider)
 
-    await env.l2Wallet.sendTransaction({
+    const sendTx = await env.l2Wallet.sendTransaction({
       to: wallet.address,
       value: utils.parseEther('0.1'),
     })
+    await sendTx.wait()
 
     for (const token of tokens) {
       let tx = await token.transfer(wallet.address, 1000000)