Commit 381bbb81 authored by protolambda's avatar protolambda

derive: remove outdated channel-out TODOs

parent 5f5db777
...@@ -91,7 +91,7 @@ func (co *SingularChannelOut) ID() ChannelID { ...@@ -91,7 +91,7 @@ func (co *SingularChannelOut) ID() ChannelID {
func NewSingularChannelOut(compress Compressor) (*SingularChannelOut, error) { func NewSingularChannelOut(compress Compressor) (*SingularChannelOut, error) {
c := &SingularChannelOut{ c := &SingularChannelOut{
id: ChannelID{}, // TODO: use GUID here instead of fully random data id: ChannelID{},
frame: 0, frame: 0,
rlpLength: 0, rlpLength: 0,
compress: compress, compress: compress,
...@@ -104,7 +104,6 @@ func NewSingularChannelOut(compress Compressor) (*SingularChannelOut, error) { ...@@ -104,7 +104,6 @@ func NewSingularChannelOut(compress Compressor) (*SingularChannelOut, error) {
return c, nil return c, nil
} }
// TODO: reuse SingularChannelOut for performance
func (co *SingularChannelOut) Reset() error { func (co *SingularChannelOut) Reset() error {
co.frame = 0 co.frame = 0
co.rlpLength = 0 co.rlpLength = 0
......
...@@ -34,7 +34,7 @@ func (co *SpanChannelOut) ID() ChannelID { ...@@ -34,7 +34,7 @@ func (co *SpanChannelOut) ID() ChannelID {
func NewSpanChannelOut(compress Compressor, spanBatchBuilder *SpanBatchBuilder) (*SpanChannelOut, error) { func NewSpanChannelOut(compress Compressor, spanBatchBuilder *SpanBatchBuilder) (*SpanChannelOut, error) {
c := &SpanChannelOut{ c := &SpanChannelOut{
id: ChannelID{}, // TODO: use GUID here instead of fully random data id: ChannelID{},
frame: 0, frame: 0,
rlpLength: 0, rlpLength: 0,
compress: compress, compress: compress,
...@@ -49,7 +49,6 @@ func NewSpanChannelOut(compress Compressor, spanBatchBuilder *SpanBatchBuilder) ...@@ -49,7 +49,6 @@ func NewSpanChannelOut(compress Compressor, spanBatchBuilder *SpanBatchBuilder)
return c, nil return c, nil
} }
// TODO: reuse ChannelOut for performance
func (co *SpanChannelOut) Reset() error { func (co *SpanChannelOut) Reset() error {
co.frame = 0 co.frame = 0
co.rlpLength = 0 co.rlpLength = 0
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment