Skip to content

N
nebula
Commit 45fa82ec authored by OptimismBot's avatar OptimismBot Committed by GitHub
Browse files
Options

Merge pull request #5653 from ethereum-optimism/jg/cleanup 

Use strings package to check for a prefix
parents 25b5f1cc 68c9c9e7
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
op-challenger/flags/flags_test.go
View file @ 45fa82ec
...@@ -40,7 +40,7 @@ func TestCorrectEnvVarPrefix(t *testing.T) { ...@@ -40,7 +40,7 @@ func TestCorrectEnvVarPrefix(t *testing.T) {
if envVar == "" { if envVar == "" {
t.Errorf("Failed to find EnvVar for flag %v", flag.GetName()) t.Errorf("Failed to find EnvVar for flag %v", flag.GetName())
} }
if envVar[:len("OP_CHALLENGER_")] != "OP_CHALLENGER_" { if !strings.HasPrefix(envVar, "OP_CHALLENGER_") {
t.Errorf("Flag %v env var (%v) does not start with OP_CHALLENGER_", flag.GetName(), envVar) t.Errorf("Flag %v env var (%v) does not start with OP_CHALLENGER_", flag.GetName(), envVar)
} }
if strings.Contains(envVar, "__") { if strings.Contains(envVar, "__") {
......
op-program/host/flags/flags_test.go
View file @ 45fa82ec
...@@ -40,7 +40,7 @@ func TestCorrectEnvVarPrefix(t *testing.T) { ...@@ -40,7 +40,7 @@ func TestCorrectEnvVarPrefix(t *testing.T) {
if envVar == "" { if envVar == "" {
t.Errorf("Failed to find EnvVar for flag %v", flag.GetName()) t.Errorf("Failed to find EnvVar for flag %v", flag.GetName())
} }
if envVar[:len("OP_PROGRAM_")] != "OP_PROGRAM_" { if !strings.HasPrefix(envVar, "OP_PROGRAM_") {
t.Errorf("Flag %v env var (%v) does not start with OP_PROGRAM_", flag.GetName(), envVar) t.Errorf("Flag %v env var (%v) does not start with OP_PROGRAM_", flag.GetName(), envVar)
} }
if strings.Contains(envVar, "__") { if strings.Contains(envVar, "__") {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment