Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
49688ddb
Unverified
Commit
49688ddb
authored
Dec 06, 2022
by
mergify[bot]
Committed by
GitHub
Dec 06, 2022
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #4241 from ethereum-optimism/sc/sdk-rm-unused-var
maint(sdk): remove unused variable
parents
78d94606
767585b0
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
41 deletions
+5
-41
cold-mangos-explain.md
.changeset/cold-mangos-explain.md
+5
-0
cross-chain-messenger.ts
packages/sdk/src/cross-chain-messenger.ts
+0
-41
No files found.
.changeset/cold-mangos-explain.md
0 → 100644
View file @
49688ddb
---
'
@eth-optimism/sdk'
:
patch
---
Removes an unused variable from the SDK
packages/sdk/src/cross-chain-messenger.ts
View file @
49688ddb
...
@@ -116,11 +116,6 @@ export class CrossChainMessenger {
...
@@ -116,11 +116,6 @@ export class CrossChainMessenger {
*/
*/
public
bedrock
:
boolean
public
bedrock
:
boolean
/**
* Parameters for the L2OutputOracle contract.
*/
private
_l2OutputOracleParameters
:
L2OutputOracleParameters
/**
/**
* Creates a new CrossChainProvider instance.
* Creates a new CrossChainProvider instance.
*
*
...
@@ -228,42 +223,6 @@ export class CrossChainMessenger {
...
@@ -228,42 +223,6 @@ export class CrossChainMessenger {
}
}
}
}
/**
* Accesses the L2OutputOracle parameters, with caching to avoid unnecessary requests.
*
* @returns The L2OutputOracle parameters.
*/
public
async
getL2OutputOracleParameters
():
Promise
<
L2OutputOracleParameters
>
{
if
(
this
.
_l2OutputOracleParameters
)
{
return
this
.
_l2OutputOracleParameters
}
// Temporary logic to support legacy Bedrock testnets.
// TODO: Remove this once all legacy testnets are deprecated.
let
startingBlockNumber
:
number
try
{
startingBlockNumber
=
(
await
this
.
contracts
.
l1
.
L2OutputOracle
.
startingBlockNumber
()
).
toNumber
()
}
catch
{
startingBlockNumber
=
(
await
this
.
contracts
.
l1
.
L2OutputOracle
.
STARTING_BLOCK_NUMBER
()
).
toNumber
()
}
this
.
_l2OutputOracleParameters
=
{
startingBlockNumber
,
submissionInterval
:
(
await
this
.
contracts
.
l1
.
L2OutputOracle
.
SUBMISSION_INTERVAL
()
).
toNumber
(),
l2BlockTime
:
(
await
this
.
contracts
.
l1
.
L2OutputOracle
.
L2_BLOCK_TIME
()
).
toNumber
(),
}
return
this
.
_l2OutputOracleParameters
}
/**
/**
* Retrieves all cross chain messages sent within a given transaction.
* Retrieves all cross chain messages sent within a given transaction.
*
*
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment