Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
5512a77b
Unverified
Commit
5512a77b
authored
Dec 09, 2023
by
0xn4de
Committed by
GitHub
Dec 09, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix wording in span-batches.md
parent
0a7104c4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
span-batches.md
specs/span-batches.md
+2
-2
No files found.
specs/span-batches.md
View file @
5512a77b
...
@@ -160,7 +160,7 @@ equal to `MAX_RLP_BYTES_PER_CHANNEL`). Therefore every field size of span batch
...
@@ -160,7 +160,7 @@ equal to `MAX_RLP_BYTES_PER_CHANNEL`). Therefore every field size of span batch
`MAX_SPAN_BATCH_SIZE`
. There can be at least single span batch per channel, and channel size is limited
`MAX_SPAN_BATCH_SIZE`
. There can be at least single span batch per channel, and channel size is limited
to
`MAX_RLP_BYTES_PER_CHANNEL`
and you may think that there is already an implicit limit. However, having an explicit
to
`MAX_RLP_BYTES_PER_CHANNEL`
and you may think that there is already an implicit limit. However, having an explicit
limit for span batch is helpful for several reasons. We may save computation costs by avoiding malicious input while
limit for span batch is helpful for several reasons. We may save computation costs by avoiding malicious input while
decoding. For example, lets say bad batcher wrote span batch which
`block_count = max.Uint64`
. We may early return using
decoding. For example, let
'
s say bad batcher wrote span batch which
`block_count = max.Uint64`
. We may early return using
the explicit limit, not trying to consume data until EOF is reached. We can also safely preallocate memory for decoding
the explicit limit, not trying to consume data until EOF is reached. We can also safely preallocate memory for decoding
because we know the upper limit of memory usage.
because we know the upper limit of memory usage.
...
@@ -203,7 +203,7 @@ This adds more complexity, but organizes data for improved compression by groupi
...
@@ -203,7 +203,7 @@ This adds more complexity, but organizes data for improved compression by groupi
### RLP encoding for only variable length fields
### RLP encoding for only variable length fields
Further size optimization can be done by packing variable length fields, such as
`access_list`
.
Further size optimization can be done by packing variable length fields, such as
`access_list`
.
However, doing this will introduce much more code complexity, compar
ing to benefiting by
size reduction.
However, doing this will introduce much more code complexity, compar
ed to benefiting from
size reduction.
Our goal is to find the sweet spot on code complexity - span batch size tradeoff.
Our goal is to find the sweet spot on code complexity - span batch size tradeoff.
I decided that using RLP for all variable length fields will be the best option,
I decided that using RLP for all variable length fields will be the best option,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment