Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
564b0c17
Unverified
Commit
564b0c17
authored
Dec 05, 2024
by
zhiqiangxu
Committed by
GitHub
Dec 05, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
NewChannelBuilder => newChannelBuilder, and move it into channel_builder_test.go (#13148)
parent
25972bd8
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
40 additions
and
39 deletions
+40
-39
channel_builder.go
op-batcher/batcher/channel_builder.go
+0
-12
channel_builder_test.go
op-batcher/batcher/channel_builder_test.go
+40
-27
No files found.
op-batcher/batcher/channel_builder.go
View file @
564b0c17
...
@@ -88,18 +88,6 @@ type ChannelBuilder struct {
...
@@ -88,18 +88,6 @@ type ChannelBuilder struct {
outputBytes
int
outputBytes
int
}
}
// NewChannelBuilder creates a new channel builder or returns an error if the
// channel out could not be created.
// it acts as a factory for either a span or singular channel out
func
NewChannelBuilder
(
cfg
ChannelConfig
,
rollupCfg
*
rollup
.
Config
,
latestL1OriginBlockNum
uint64
)
(
*
ChannelBuilder
,
error
)
{
co
,
err
:=
NewChannelOut
(
cfg
,
rollupCfg
)
if
err
!=
nil
{
return
nil
,
fmt
.
Errorf
(
"creating channel out: %w"
,
err
)
}
return
NewChannelBuilderWithChannelOut
(
cfg
,
rollupCfg
,
latestL1OriginBlockNum
,
co
),
nil
}
func
NewChannelBuilderWithChannelOut
(
cfg
ChannelConfig
,
rollupCfg
*
rollup
.
Config
,
latestL1OriginBlockNum
uint64
,
channelOut
derive
.
ChannelOut
)
*
ChannelBuilder
{
func
NewChannelBuilderWithChannelOut
(
cfg
ChannelConfig
,
rollupCfg
*
rollup
.
Config
,
latestL1OriginBlockNum
uint64
,
channelOut
derive
.
ChannelOut
)
*
ChannelBuilder
{
cb
:=
&
ChannelBuilder
{
cb
:=
&
ChannelBuilder
{
cfg
:
cfg
,
cfg
:
cfg
,
...
...
op-batcher/batcher/channel_builder_test.go
View file @
564b0c17
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment