Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
57c008ef
Unverified
Commit
57c008ef
authored
Apr 25, 2023
by
Sebastian Stammler
Committed by
GitHub
Apr 25, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #5510 from ethereum-optimism/jg/flags
op-batcher,proposer: Default previously required flags
parents
334a7515
98291fbc
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
12 deletions
+15
-12
flags.go
op-batcher/flags/flags.go
+8
-7
flags.go
op-proposer/flags/flags.go
+7
-5
No files found.
op-batcher/flags/flags.go
View file @
57c008ef
...
@@ -2,6 +2,7 @@ package flags
...
@@ -2,6 +2,7 @@ package flags
import
(
import
(
"fmt"
"fmt"
"time"
"github.com/urfave/cli"
"github.com/urfave/cli"
...
@@ -33,21 +34,21 @@ var (
...
@@ -33,21 +34,21 @@ var (
Usage
:
"HTTP provider URL for Rollup node"
,
Usage
:
"HTTP provider URL for Rollup node"
,
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"ROLLUP_RPC"
),
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"ROLLUP_RPC"
),
}
}
// Optional flags
SubSafetyMarginFlag
=
cli
.
Uint64Flag
{
SubSafetyMarginFlag
=
cli
.
Uint64Flag
{
Name
:
"sub-safety-margin"
,
Name
:
"sub-safety-margin"
,
Usage
:
"The batcher tx submission safety margin (in #L1-blocks) to subtract "
+
Usage
:
"The batcher tx submission safety margin (in #L1-blocks) to subtract "
+
"from a channel's timeout and sequencing window, to guarantee safe inclusion "
+
"from a channel's timeout and sequencing window, to guarantee safe inclusion "
+
"of a channel on L1."
,
"of a channel on L1."
,
Value
:
10
,
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"SUB_SAFETY_MARGIN"
),
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"SUB_SAFETY_MARGIN"
),
}
}
PollIntervalFlag
=
cli
.
DurationFlag
{
PollIntervalFlag
=
cli
.
DurationFlag
{
Name
:
"poll-interval"
,
Name
:
"poll-interval"
,
Usage
:
"Delay between querying L2 for more transactions and "
+
Usage
:
"How frequently to poll L2 for new blocks"
,
"creating a new batch"
,
Value
:
6
*
time
.
Second
,
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"POLL_INTERVAL"
),
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"POLL_INTERVAL"
),
}
}
// Optional flags
MaxPendingTransactionsFlag
=
cli
.
Uint64Flag
{
MaxPendingTransactionsFlag
=
cli
.
Uint64Flag
{
Name
:
"max-pending-tx"
,
Name
:
"max-pending-tx"
,
Usage
:
"The maximum number of pending transactions. 0 for no limit."
,
Usage
:
"The maximum number of pending transactions. 0 for no limit."
,
...
@@ -97,11 +98,11 @@ var requiredFlags = []cli.Flag{
...
@@ -97,11 +98,11 @@ var requiredFlags = []cli.Flag{
L1EthRpcFlag
,
L1EthRpcFlag
,
L2EthRpcFlag
,
L2EthRpcFlag
,
RollupRpcFlag
,
RollupRpcFlag
,
SubSafetyMarginFlag
,
PollIntervalFlag
,
}
}
var
optionalFlags
=
[]
cli
.
Flag
{
var
optionalFlags
=
[]
cli
.
Flag
{
SubSafetyMarginFlag
,
PollIntervalFlag
,
MaxPendingTransactionsFlag
,
MaxPendingTransactionsFlag
,
MaxChannelDurationFlag
,
MaxChannelDurationFlag
,
MaxL1TxSizeBytesFlag
,
MaxL1TxSizeBytesFlag
,
...
...
op-proposer/flags/flags.go
View file @
57c008ef
...
@@ -2,6 +2,7 @@ package flags
...
@@ -2,6 +2,7 @@ package flags
import
(
import
(
"fmt"
"fmt"
"time"
"github.com/urfave/cli"
"github.com/urfave/cli"
...
@@ -32,13 +33,14 @@ var (
...
@@ -32,13 +33,14 @@ var (
Usage
:
"Address of the L2OutputOracle contract"
,
Usage
:
"Address of the L2OutputOracle contract"
,
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"L2OO_ADDRESS"
),
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"L2OO_ADDRESS"
),
}
}
// Optional flags
PollIntervalFlag
=
cli
.
DurationFlag
{
PollIntervalFlag
=
cli
.
DurationFlag
{
Name
:
"poll-interval"
,
Name
:
"poll-interval"
,
Usage
:
"Delay between querying L2 for more transactions and "
+
Usage
:
"How frequently to poll L2 for new blocks"
,
"creating a new batch"
,
Value
:
6
*
time
.
Second
,
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"POLL_INTERVAL"
),
EnvVar
:
opservice
.
PrefixEnvVar
(
envVarPrefix
,
"POLL_INTERVAL"
),
}
}
// Optional flags
AllowNonFinalizedFlag
=
cli
.
BoolFlag
{
AllowNonFinalizedFlag
=
cli
.
BoolFlag
{
Name
:
"allow-non-finalized"
,
Name
:
"allow-non-finalized"
,
Usage
:
"Allow the proposer to submit proposals for L2 blocks derived from non-finalized L1 blocks."
,
Usage
:
"Allow the proposer to submit proposals for L2 blocks derived from non-finalized L1 blocks."
,
...
@@ -52,10 +54,10 @@ var requiredFlags = []cli.Flag{
...
@@ -52,10 +54,10 @@ var requiredFlags = []cli.Flag{
L1EthRpcFlag
,
L1EthRpcFlag
,
RollupRpcFlag
,
RollupRpcFlag
,
L2OOAddressFlag
,
L2OOAddressFlag
,
PollIntervalFlag
,
}
}
var
optionalFlags
=
[]
cli
.
Flag
{
var
optionalFlags
=
[]
cli
.
Flag
{
PollIntervalFlag
,
AllowNonFinalizedFlag
,
AllowNonFinalizedFlag
,
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment