Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
599101ca
Commit
599101ca
authored
Nov 22, 2022
by
clabby
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix John's nits
parent
9f02838a
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
5 deletions
+5
-5
optimismportal.go
op-bindings/bindings/optimismportal.go
+1
-1
optimismportal_more.go
op-bindings/bindings/optimismportal_more.go
+1
-1
OptimismPortal.sol
packages/contracts-bedrock/contracts/L1/OptimismPortal.sol
+2
-2
OptimismPortal.t.sol
...ges/contracts-bedrock/contracts/test/OptimismPortal.t.sol
+1
-1
No files found.
op-bindings/bindings/optimismportal.go
View file @
599101ca
This diff is collapsed.
Click to expand it.
op-bindings/bindings/optimismportal_more.go
View file @
599101ca
This diff is collapsed.
Click to expand it.
packages/contracts-bedrock/contracts/L1/OptimismPortal.sol
View file @
599101ca
...
@@ -197,7 +197,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver {
...
@@ -197,7 +197,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver {
provenWithdrawal.timestamp == 0 ||
provenWithdrawal.timestamp == 0 ||
(_l2BlockNumber == provenWithdrawal.l2BlockNumber &&
(_l2BlockNumber == provenWithdrawal.l2BlockNumber &&
outputRoot != provenWithdrawal.outputRoot),
outputRoot != provenWithdrawal.outputRoot),
"OptimismPortal: withdrawal
H
ash has already been proven"
"OptimismPortal: withdrawal
h
ash has already been proven"
);
);
// Verify that the hash of this withdrawal was stored in the L2toL1MessagePasser contract on
// Verify that the hash of this withdrawal was stored in the L2toL1MessagePasser contract on
...
@@ -214,7 +214,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver {
...
@@ -214,7 +214,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver {
// Designate the withdrawalHash as proven by storing the `outputRoot`, `timestamp`,
// Designate the withdrawalHash as proven by storing the `outputRoot`, `timestamp`,
// and `l2BlockNumber` in the `provenWithdrawals` mapping. A withdrawalHash can only
// and `l2BlockNumber` in the `provenWithdrawals` mapping. A withdrawalHash can only
// be proven on
e tim
e to prevent a censorship attack unless it is submitted again
// be proven on
c
e to prevent a censorship attack unless it is submitted again
// with a different outputRoot.
// with a different outputRoot.
provenWithdrawals[withdrawalHash] = ProvenWithdrawal({
provenWithdrawals[withdrawalHash] = ProvenWithdrawal({
outputRoot: outputRoot,
outputRoot: outputRoot,
...
...
packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol
View file @
599101ca
...
@@ -383,7 +383,7 @@ contract OptimismPortal_FinalizeWithdrawal_Test is Portal_Initializer {
...
@@ -383,7 +383,7 @@ contract OptimismPortal_FinalizeWithdrawal_Test is Portal_Initializer {
_withdrawalProof
_withdrawalProof
);
);
vm.expectRevert("OptimismPortal: withdrawal
H
ash has already been proven");
vm.expectRevert("OptimismPortal: withdrawal
h
ash has already been proven");
op.proveWithdrawalTransaction(
op.proveWithdrawalTransaction(
_defaultTx,
_defaultTx,
_proposedBlockNumber,
_proposedBlockNumber,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment