Merge branch 'develop' into fix/err-msg

.changeset/fluffy-ducks-compare.md

+---
+'@eth-optimism/indexer': patch
+---
+
+Delete unused flags

indexer/flags/flags.go

@@ -22,12 +22,6 @@ var (
 		Required: true,
 		EnvVar:   prefixEnvVar("BUILD_ENV"),
 	}
-	EthNetworkNameFlag = cli.StringFlag{
-		Name:     "eth-network-name",
-		Usage:    "Ethereum network name",
-		Required: true,
-		EnvVar:   prefixEnvVar("ETH_NETWORK_NAME"),
-	}
 	ChainIDFlag = cli.StringFlag{
 		Name:     "chain-id",
 		Usage:    "Ethereum chain ID",
@@ -188,7 +182,6 @@ var (
 
 var requiredFlags = []cli.Flag{
 	BuildEnvFlag,
-	EthNetworkNameFlag,
 	ChainIDFlag,
 	L1EthRPCFlag,
 	L2EthRPCFlag,

packages/contracts-bedrock/contracts/test/CrossDomainMessenger.t.sol

@@ -8,12 +8,12 @@ import { Messenger_Initializer, Reverter, CallerCaller } from "./CommonTest.t.so
 contract CrossDomainMessenger_Test is Messenger_Initializer {
     // Ensure that baseGas passes for the max value of _minGasLimit,
     // this is about 4 Billion.
-    function test_baseGas() external {
+    function test_baseGas() external view {
         L1Messenger.baseGas(hex"ff", type(uint32).max);
     }
 
     // Fuzz for other values which might cause a revert in baseGas.
-    function testFuzz_baseGas(uint32 _minGasLimit) external {
+    function testFuzz_baseGas(uint32 _minGasLimit) external view {
         L1Messenger.baseGas(hex"ff", _minGasLimit);
     }
 }