Skip to content

N
nebula
Commit 655f0efe authored by Mark Tyneway's avatar Mark Tyneway
Browse files
Options

lints: fix

parent 3fa8dc0d
Hide whitespace changes
Inline Side-by-side
Showing with 59 additions and 73 deletions
packages/contracts-bedrock/.gas-snapshot
View file @ 655f0efe
...@@ -401,6 +401,7 @@ MintManager_mint_Test:test_mint_moreThanCap_reverts() (gas: 142523) ...@@ -401,6 +401,7 @@ MintManager_mint_Test:test_mint_moreThanCap_reverts() (gas: 142523)
MintManager_upgrade_Test:test_upgrade_fromNotOwner_reverts() (gas: 10974) MintManager_upgrade_Test:test_upgrade_fromNotOwner_reverts() (gas: 10974)
MintManager_upgrade_Test:test_upgrade_fromOwner_succeeds() (gas: 23434) MintManager_upgrade_Test:test_upgrade_fromOwner_succeeds() (gas: 23434)
MintManager_upgrade_Test:test_upgrade_toZeroAddress_reverts() (gas: 11003) MintManager_upgrade_Test:test_upgrade_toZeroAddress_reverts() (gas: 11003)
Multichain:test_script_succeeds() (gas: 3078)
OptimismMintableERC20_Test:test_bridge_succeeds() (gas: 7621) OptimismMintableERC20_Test:test_bridge_succeeds() (gas: 7621)
OptimismMintableERC20_Test:test_burn_notBridge_reverts() (gas: 11164) OptimismMintableERC20_Test:test_burn_notBridge_reverts() (gas: 11164)
OptimismMintableERC20_Test:test_burn_succeeds() (gas: 50996) OptimismMintableERC20_Test:test_burn_succeeds() (gas: 50996)
...@@ -517,8 +518,6 @@ OptimistTest:test_supportsInterface_returnsCorrectInterfaceForERC721_succeeds() ...@@ -517,8 +518,6 @@ OptimistTest:test_supportsInterface_returnsCorrectInterfaceForERC721_succeeds()
OptimistTest:test_tokenIdOfAddress_returnsOwnerID_succeeds() (gas: 63730) OptimistTest:test_tokenIdOfAddress_returnsOwnerID_succeeds() (gas: 63730)
OptimistTest:test_tokenURI_returnsCorrectTokenURI_succeeds() (gas: 195908) OptimistTest:test_tokenURI_returnsCorrectTokenURI_succeeds() (gas: 195908)
OptimistTest:test_transferFrom_soulbound_reverts() (gas: 75512) OptimistTest:test_transferFrom_soulbound_reverts() (gas: 75512)
PostSherlockL1:test_script_succeeds() (gas: 3078)
PostSherlockL2:test_script_succeeds() (gas: 3078)
PreimageOracle_Test:test_keccak256PreimageKey_succeeds() (gas: 319) PreimageOracle_Test:test_keccak256PreimageKey_succeeds() (gas: 319)
PreimageOracle_Test:test_loadKeccak256PreimagePart_outOfBoundsOffset_reverts() (gas: 8993) PreimageOracle_Test:test_loadKeccak256PreimagePart_outOfBoundsOffset_reverts() (gas: 8993)
PreimageOracle_Test:test_loadKeccak256PreimagePart_succeeds() (gas: 76098) PreimageOracle_Test:test_loadKeccak256PreimagePart_succeeds() (gas: 76098)
......
packages/contracts-bedrock/scripts/upgrades/Multichain.s.sol
View file @ 655f0efe
...@@ -155,7 +155,8 @@ contract Multichain is SafeBuilder { ...@@ -155,7 +155,8 @@ contract Multichain is SafeBuilder {
"L1CrossDomainMessenger codehash" "L1CrossDomainMessenger codehash"
); );
require( require(
PROXY_ADMIN.getProxyImplementation(prox.L1StandardBridge).codehash == L1StandardBridgeImplementation.codehash, PROXY_ADMIN.getProxyImplementation(prox.L1StandardBridge).codehash
== L1StandardBridgeImplementation.codehash,
"L1StandardBridge codehash" "L1StandardBridge codehash"
); );
require( require(
...@@ -230,14 +231,10 @@ contract Multichain is SafeBuilder { ...@@ -230,14 +231,10 @@ contract Multichain is SafeBuilder {
( (
payable(prox.L1CrossDomainMessenger), // proxy payable(prox.L1CrossDomainMessenger), // proxy
L1CrossDomainMessengerImplementation, // implementation L1CrossDomainMessengerImplementation, // implementation
abi.encodeCall( // data abi.encodeCall( // data
L1CrossDomainMessenger.initialize, L1CrossDomainMessenger.initialize, (OptimismPortal(payable(prox.OptimismPortal))))
( )
OptimismPortal(payable(prox.OptimismPortal))
)
)
) )
)
}); });
// Upgrade the L1StandardBridge // Upgrade the L1StandardBridge
...@@ -247,16 +244,11 @@ contract Multichain is SafeBuilder { ...@@ -247,16 +244,11 @@ contract Multichain is SafeBuilder {
callData: abi.encodeCall( callData: abi.encodeCall(
ProxyAdmin.upgradeAndCall, ProxyAdmin.upgradeAndCall,
( (
payable(prox.L1StandardBridge), // proxy payable(prox.L1StandardBridge), // proxy
L1StandardBridgeImplementation, // implementation L1StandardBridgeImplementation, // implementation
abi.encodeCall( abi.encodeCall(L1StandardBridge.initialize, (L1CrossDomainMessenger(prox.L1CrossDomainMessenger)))
L1StandardBridge.initialize, )
(
L1CrossDomainMessenger(prox.L1CrossDomainMessenger)
)
)
) )
)
}); });
// Upgrade the L2OutputOracle // Upgrade the L2OutputOracle
...@@ -266,19 +258,19 @@ contract Multichain is SafeBuilder { ...@@ -266,19 +258,19 @@ contract Multichain is SafeBuilder {
callData: abi.encodeCall( callData: abi.encodeCall(
ProxyAdmin.upgradeAndCall, ProxyAdmin.upgradeAndCall,
( (
payable(prox.L2OutputOracle), // proxy payable(prox.L2OutputOracle), // proxy
L2OutputOracleImplementation, // implementation L2OutputOracleImplementation, // implementation
abi.encodeCall( // data abi.encodeCall( // data
L2OutputOracle.initialize, L2OutputOracle.initialize,
( (
cfg.l2OutputOracleStartingBlockNumber(), cfg.l2OutputOracleStartingBlockNumber(),
l2OutputOracleStartingTimestamp, l2OutputOracleStartingTimestamp,
cfg.l2OutputOracleProposer(), cfg.l2OutputOracleProposer(),
cfg.l2OutputOracleChallenger() cfg.l2OutputOracleChallenger()
)
) )
)
) )
) )
}); });
// Upgrade the OptimismMintableERC20Factory. No initialize function. // Upgrade the OptimismMintableERC20Factory. No initialize function.
...@@ -287,7 +279,7 @@ contract Multichain is SafeBuilder { ...@@ -287,7 +279,7 @@ contract Multichain is SafeBuilder {
allowFailure: false, allowFailure: false,
callData: abi.encodeCall( callData: abi.encodeCall(
ProxyAdmin.upgrade, (payable(prox.OptimismMintableERC20Factory), OptimismMintableERC20FactoryImplementation) ProxyAdmin.upgrade, (payable(prox.OptimismMintableERC20Factory), OptimismMintableERC20FactoryImplementation)
) )
}); });
// Upgrade the OptimismPortal // Upgrade the OptimismPortal
...@@ -297,19 +289,19 @@ contract Multichain is SafeBuilder { ...@@ -297,19 +289,19 @@ contract Multichain is SafeBuilder {
callData: abi.encodeCall( callData: abi.encodeCall(
ProxyAdmin.upgradeAndCall, ProxyAdmin.upgradeAndCall,
( (
payable(prox.OptimismPortal), // proxy payable(prox.OptimismPortal), // proxy
OptimismPortalImplementation, // implementation OptimismPortalImplementation, // implementation
abi.encodeCall( // data abi.encodeCall( // data
OptimismPortal.initialize, OptimismPortal.initialize,
( (
L2OutputOracle(prox.L2OutputOracle), L2OutputOracle(prox.L2OutputOracle),
cfg.portalGuardian(), cfg.portalGuardian(),
SystemConfig(prox.SystemConfig), SystemConfig(prox.SystemConfig),
false false
)
) )
)
) )
) )
}); });
// Upgrade the SystemConfig // Upgrade the SystemConfig
...@@ -319,32 +311,32 @@ contract Multichain is SafeBuilder { ...@@ -319,32 +311,32 @@ contract Multichain is SafeBuilder {
callData: abi.encodeCall( callData: abi.encodeCall(
ProxyAdmin.upgradeAndCall, ProxyAdmin.upgradeAndCall,
( (
payable(prox.SystemConfig), // proxy payable(prox.SystemConfig), // proxy
SystemConfigImplementation, // implementation SystemConfigImplementation, // implementation
abi.encodeCall( // data abi.encodeCall( // data
SystemConfig.initialize, SystemConfig.initialize,
( (
cfg.finalSystemOwner(), cfg.finalSystemOwner(),
cfg.gasPriceOracleOverhead(), cfg.gasPriceOracleOverhead(),
cfg.gasPriceOracleScalar(), cfg.gasPriceOracleScalar(),
bytes32(uint256(uint160(cfg.batchSenderAddress()))), bytes32(uint256(uint160(cfg.batchSenderAddress()))),
uint64(cfg.l2GenesisBlockGasLimit()), uint64(cfg.l2GenesisBlockGasLimit()),
cfg.p2pSequencerAddress(), cfg.p2pSequencerAddress(),
Constants.DEFAULT_RESOURCE_CONFIG(), Constants.DEFAULT_RESOURCE_CONFIG(),
cfg.systemConfigStartBlock(), cfg.systemConfigStartBlock(),
cfg.batchInboxAddress(), cfg.batchInboxAddress(),
SystemConfig.Addresses({ SystemConfig.Addresses({
l1CrossDomainMessenger: prox.L1CrossDomainMessenger, l1CrossDomainMessenger: prox.L1CrossDomainMessenger,
l1ERC721Bridge: prox.L1ERC721Bridge, l1ERC721Bridge: prox.L1ERC721Bridge,
l1StandardBridge: prox.L1StandardBridge, l1StandardBridge: prox.L1StandardBridge,
l2OutputOracle: prox.L2OutputOracle, l2OutputOracle: prox.L2OutputOracle,
optimismPortal: prox.OptimismPortal, optimismPortal: prox.OptimismPortal,
optimismMintableERC20Factory: prox.OptimismMintableERC20Factory optimismMintableERC20Factory: prox.OptimismMintableERC20Factory
}) })
)
) )
)
) )
) )
}); });
// Upgrade the L1ERC721Bridge // Upgrade the L1ERC721Bridge
...@@ -356,14 +348,9 @@ contract Multichain is SafeBuilder { ...@@ -356,14 +348,9 @@ contract Multichain is SafeBuilder {
( (
payable(prox.L1ERC721Bridge), payable(prox.L1ERC721Bridge),
L1ERC721BridgeImplementation, L1ERC721BridgeImplementation,
abi.encodeCall( abi.encodeCall(L1ERC721Bridge.initialize, (L1CrossDomainMessenger(prox.L1CrossDomainMessenger)))
L1ERC721Bridge.initialize, )
(
L1CrossDomainMessenger(prox.L1CrossDomainMessenger)
)
)
) )
)
}); });
return abi.encodeCall(IMulticall3.aggregate3, (calls)); return abi.encodeCall(IMulticall3.aggregate3, (calls));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment