Skip to content

N
nebula
Commit 672ff9f9 authored by Wyatt Barnes's avatar Wyatt Barnes
Browse files
Options

Remove unused returnFormat parameter

parent baaf21cd
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 6 deletions
packages/web3.js-plugin-fee-estimation/src/plugin.ts
View file @ 672ff9f9
...@@ -6,7 +6,6 @@ import Web3, { ...@@ -6,7 +6,6 @@ import Web3, {
DEFAULT_RETURN_FORMAT, DEFAULT_RETURN_FORMAT,
FMT_BYTES, FMT_BYTES,
FMT_NUMBER, FMT_NUMBER,
type Numbers,
type Transaction, type Transaction,
Web3PluginBase, Web3PluginBase,
} from 'web3' } from 'web3'
...@@ -103,7 +102,7 @@ export class OptimismFeeEstimationPlugin extends Web3PluginBase { ...@@ -103,7 +102,7 @@ export class OptimismFeeEstimationPlugin extends Web3PluginBase {
return Web3.utils.format( return Web3.utils.format(
{ format: 'uint' }, { format: 'uint' },
await this._getPriceOracleContractInstance() await this._getPriceOracleContractInstance()
.methods.getL1Fee(this._serializeTransaction(transaction, returnFormat)) .methods.getL1Fee(this._serializeTransaction(transaction))
.call(), .call(),
returnFormat ?? DEFAULT_RETURN_FORMAT returnFormat ?? DEFAULT_RETURN_FORMAT
) )
...@@ -130,7 +129,7 @@ export class OptimismFeeEstimationPlugin extends Web3PluginBase { ...@@ -130,7 +129,7 @@ export class OptimismFeeEstimationPlugin extends Web3PluginBase {
{ format: 'uint' }, { format: 'uint' },
await this._getPriceOracleContractInstance() await this._getPriceOracleContractInstance()
.methods.getL1GasUsed( .methods.getL1GasUsed(
this._serializeTransaction(transaction, returnFormat) this._serializeTransaction(transaction)
) )
.call(), .call(),
returnFormat ?? DEFAULT_RETURN_FORMAT returnFormat ?? DEFAULT_RETURN_FORMAT
...@@ -303,9 +302,7 @@ export class OptimismFeeEstimationPlugin extends Web3PluginBase { ...@@ -303,9 +302,7 @@ export class OptimismFeeEstimationPlugin extends Web3PluginBase {
* @param transaction - A web3.js {Transaction} object * @param transaction - A web3.js {Transaction} object
* @returns {string} - The RLP encoded hex string * @returns {string} - The RLP encoded hex string
*/ */
private _serializeTransaction< private _serializeTransaction(transaction: Transaction) {
ReturnFormat extends DataFormat = typeof DEFAULT_RETURN_FORMAT
>(transaction: Transaction, returnFormat?: ReturnFormat) {
const ethereumjsTransaction = TransactionFactory.fromTxData( const ethereumjsTransaction = TransactionFactory.fromTxData(
formatTransaction(transaction, { formatTransaction(transaction, {
number: FMT_NUMBER.HEX, number: FMT_NUMBER.HEX,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment