Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
690bcd86
Unverified
Commit
690bcd86
authored
Nov 27, 2023
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
contracts-bedrock: Address review comments
parent
f58d6e4d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
3 deletions
+2
-3
Deploy.s.sol
packages/contracts-bedrock/scripts/Deploy.s.sol
+1
-1
SuperchainConfig.sol
packages/contracts-bedrock/src/L1/SuperchainConfig.sol
+0
-1
SuperchainConfig.t.sol
packages/contracts-bedrock/test/SuperchainConfig.t.sol
+1
-1
No files found.
packages/contracts-bedrock/scripts/Deploy.s.sol
View file @
690bcd86
...
@@ -224,7 +224,7 @@ contract Deploy is Deployer {
...
@@ -224,7 +224,7 @@ contract Deploy is Deployer {
////////////////////////////////////////////////////////////////
////////////////////////////////////////////////////////////////
/// @notice Deploy a full system with a new SuperchainConfig
/// @notice Deploy a full system with a new SuperchainConfig
/// The Superchain system has
3
singleton contracts which lie outside of an OP Chain:
/// The Superchain system has
2
singleton contracts which lie outside of an OP Chain:
/// 1. The SuperchainConfig contract
/// 1. The SuperchainConfig contract
/// 2. The ProtocolVersions contract
/// 2. The ProtocolVersions contract
function setupSuperchain() public {
function setupSuperchain() public {
...
...
packages/contracts-bedrock/src/L1/SuperchainConfig.sol
View file @
690bcd86
...
@@ -4,7 +4,6 @@ pragma solidity 0.8.15;
...
@@ -4,7 +4,6 @@ pragma solidity 0.8.15;
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
import { ISemver } from "src/universal/ISemver.sol";
import { ISemver } from "src/universal/ISemver.sol";
import { Storage } from "src/libraries/Storage.sol";
import { Storage } from "src/libraries/Storage.sol";
import { Constants } from "src/libraries/Constants.sol";
/// @custom:audit none This contracts is not yet audited.
/// @custom:audit none This contracts is not yet audited.
/// @title SuperchainConfig
/// @title SuperchainConfig
...
...
packages/contracts-bedrock/test/SuperchainConfig.t.sol
View file @
690bcd86
...
@@ -44,7 +44,7 @@ contract SuperchainConfig_Pause_Test is CommonTest {
...
@@ -44,7 +44,7 @@ contract SuperchainConfig_Pause_Test is CommonTest {
vm.expectEmit(address(superchainConfig));
vm.expectEmit(address(superchainConfig));
emit Paused("identifier");
emit Paused("identifier");
vm.prank(
cfg.portalG
uardian());
vm.prank(
superchainConfig.g
uardian());
superchainConfig.pause("identifier");
superchainConfig.pause("identifier");
assertTrue(superchainConfig.paused());
assertTrue(superchainConfig.paused());
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment