Commit 690bcd86 authored by Maurelian's avatar Maurelian

contracts-bedrock: Address review comments

parent f58d6e4d
...@@ -224,7 +224,7 @@ contract Deploy is Deployer { ...@@ -224,7 +224,7 @@ contract Deploy is Deployer {
//////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////
/// @notice Deploy a full system with a new SuperchainConfig /// @notice Deploy a full system with a new SuperchainConfig
/// The Superchain system has 3 singleton contracts which lie outside of an OP Chain: /// The Superchain system has 2 singleton contracts which lie outside of an OP Chain:
/// 1. The SuperchainConfig contract /// 1. The SuperchainConfig contract
/// 2. The ProtocolVersions contract /// 2. The ProtocolVersions contract
function setupSuperchain() public { function setupSuperchain() public {
......
...@@ -4,7 +4,6 @@ pragma solidity 0.8.15; ...@@ -4,7 +4,6 @@ pragma solidity 0.8.15;
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol"; import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
import { ISemver } from "src/universal/ISemver.sol"; import { ISemver } from "src/universal/ISemver.sol";
import { Storage } from "src/libraries/Storage.sol"; import { Storage } from "src/libraries/Storage.sol";
import { Constants } from "src/libraries/Constants.sol";
/// @custom:audit none This contracts is not yet audited. /// @custom:audit none This contracts is not yet audited.
/// @title SuperchainConfig /// @title SuperchainConfig
......
...@@ -44,7 +44,7 @@ contract SuperchainConfig_Pause_Test is CommonTest { ...@@ -44,7 +44,7 @@ contract SuperchainConfig_Pause_Test is CommonTest {
vm.expectEmit(address(superchainConfig)); vm.expectEmit(address(superchainConfig));
emit Paused("identifier"); emit Paused("identifier");
vm.prank(cfg.portalGuardian()); vm.prank(superchainConfig.guardian());
superchainConfig.pause("identifier"); superchainConfig.pause("identifier");
assertTrue(superchainConfig.paused()); assertTrue(superchainConfig.paused());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment