Skip to content

N
nebula
Commit 731cfea7 authored by Maurelian's avatar Maurelian Committed by GitHub
Browse files
Options

ctb: Remove unused events from the OptimismPortal (#8637) 

These events are now in the SuperchainConfig and are no longer used here
parent 816e425c
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 49 additions and 351 deletions
op-bindings/bindings/optimismportal.go
View file @ 731cfea7
This source diff could not be displayed because it is too large. You can view the blob instead.
op-bindings/bindings/optimismportal_more.go
View file @ 731cfea7
This diff is collapsed.
packages/contracts-bedrock/semver-lock.json
View file @ 731cfea7
...@@ -28,8 +28,8 @@ ...@@ -28,8 +28,8 @@
"sourceCodeHash": "0xb99ee58a672ed59f6bf529a618d4949f198bfda7c65664c9b2a2657070756c69" "sourceCodeHash": "0xb99ee58a672ed59f6bf529a618d4949f198bfda7c65664c9b2a2657070756c69"
}, },
"src/L1/OptimismPortal.sol": { "src/L1/OptimismPortal.sol": {
"initCodeHash": "0xc44238f1b97d7958baad77aea821de399cff040ab987c66946c1e3c6d6e20333", "initCodeHash": "0xd4e41857cb584fcb374f3636f9ea365c20972948d4c922b5388f416f4c9e8ef2",
"sourceCodeHash": "0x62908d2190dd0294ed4cde583e85233d8acfb118bae219957353746c5db3b4c3" "sourceCodeHash": "0xadece71739b0a6b5427cbae5b53a2c7f7d4b5f978c028dbce2f536b1229f37f8"
}, },
"src/L1/ProtocolVersions.sol": { "src/L1/ProtocolVersions.sol": {
"initCodeHash": "0x72cd467e8bcf019c02675d72ab762e088bcc9cc0f1a4e9f587fa4589f7fdd1b8", "initCodeHash": "0x72cd467e8bcf019c02675d72ab762e088bcc9cc0f1a4e9f587fa4589f7fdd1b8",
......
packages/contracts-bedrock/slither-report.json
View file @ 731cfea7
...@@ -1260,26 +1260,26 @@ ...@@ -1260,26 +1260,26 @@
"filename_relative": "src/universal/CrossDomainMessenger.sol" "filename_relative": "src/universal/CrossDomainMessenger.sol"
}, },
{ {
"id": "abea83e11d409c6cde17efdfe955c3a9f5ab92a0bc6720d631933eb091de0c77", "id": "6b52fad833e1120044d0d5364441efdf7e7d9f3988885eaeb83816ee433b43ea",
"impact": "Medium", "impact": "Medium",
"confidence": "Medium", "confidence": "Medium",
"check": "tx-origin", "check": "tx-origin",
"description": "OptimismPortal.finalizeWithdrawalTransaction(Types.WithdrawalTransaction) (src/L1/OptimismPortal.sol#272-355) uses tx.origin for authorization: success == false && tx.origin == Constants.ESTIMATION_ADDRESS (src/L1/OptimismPortal.sol#352)\n", "description": "OptimismPortal.finalizeWithdrawalTransaction(Types.WithdrawalTransaction) (src/L1/OptimismPortal.sol#264-347) uses tx.origin for authorization: success == false && tx.origin == Constants.ESTIMATION_ADDRESS (src/L1/OptimismPortal.sol#344)\n",
"type": "function", "type": "function",
"name": "finalizeWithdrawalTransaction", "name": "finalizeWithdrawalTransaction",
"start": 13146, "start": 12831,
"length": 4841, "length": 4841,
"filename_relative": "src/L1/OptimismPortal.sol" "filename_relative": "src/L1/OptimismPortal.sol"
}, },
{ {
"id": "abea83e11d409c6cde17efdfe955c3a9f5ab92a0bc6720d631933eb091de0c77", "id": "6b52fad833e1120044d0d5364441efdf7e7d9f3988885eaeb83816ee433b43ea",
"impact": "Medium", "impact": "Medium",
"confidence": "Medium", "confidence": "Medium",
"check": "tx-origin", "check": "tx-origin",
"description": "OptimismPortal.finalizeWithdrawalTransaction(Types.WithdrawalTransaction) (src/L1/OptimismPortal.sol#272-355) uses tx.origin for authorization: success == false && tx.origin == Constants.ESTIMATION_ADDRESS (src/L1/OptimismPortal.sol#352)\n", "description": "OptimismPortal.finalizeWithdrawalTransaction(Types.WithdrawalTransaction) (src/L1/OptimismPortal.sol#264-347) uses tx.origin for authorization: success == false && tx.origin == Constants.ESTIMATION_ADDRESS (src/L1/OptimismPortal.sol#344)\n",
"type": "node", "type": "node",
"name": "success == false && tx.origin == Constants.ESTIMATION_ADDRESS", "name": "success == false && tx.origin == Constants.ESTIMATION_ADDRESS",
"start": 17850, "start": 17535,
"length": 61, "length": 61,
"filename_relative": "src/L1/OptimismPortal.sol" "filename_relative": "src/L1/OptimismPortal.sol"
}, },
...@@ -1319,42 +1319,6 @@ ...@@ -1319,42 +1319,6 @@
"length": 22, "length": 22,
"filename_relative": "src/dispute/OutputBisectionGame.sol" "filename_relative": "src/dispute/OutputBisectionGame.sol"
}, },
{
"id": "31cd4889732cd7c264fbe798960cae4b02c6d6f07d31596ceba32a2aaf3db8f7",
"impact": "Medium",
"confidence": "High",
"check": "write-after-write",
"description": "OptimismPortal.l2Sender (src/L1/OptimismPortal.sol#53) is written in both\n\tl2Sender = _tx.sender (src/L1/OptimismPortal.sol#331)\n\tl2Sender = Constants.DEFAULT_L2_SENDER (src/L1/OptimismPortal.sol#343)\n",
"type": "variable",
"name": "l2Sender",
"start": 2603,
"length": 23,
"filename_relative": "src/L1/OptimismPortal.sol"
},
{
"id": "31cd4889732cd7c264fbe798960cae4b02c6d6f07d31596ceba32a2aaf3db8f7",
"impact": "Medium",
"confidence": "High",
"check": "write-after-write",
"description": "OptimismPortal.l2Sender (src/L1/OptimismPortal.sol#53) is written in both\n\tl2Sender = _tx.sender (src/L1/OptimismPortal.sol#331)\n\tl2Sender = Constants.DEFAULT_L2_SENDER (src/L1/OptimismPortal.sol#343)\n",
"type": "node",
"name": "l2Sender = _tx.sender",
"start": 16551,
"length": 21,
"filename_relative": "src/L1/OptimismPortal.sol"
},
{
"id": "31cd4889732cd7c264fbe798960cae4b02c6d6f07d31596ceba32a2aaf3db8f7",
"impact": "Medium",
"confidence": "High",
"check": "write-after-write",
"description": "OptimismPortal.l2Sender (src/L1/OptimismPortal.sol#53) is written in both\n\tl2Sender = _tx.sender (src/L1/OptimismPortal.sol#331)\n\tl2Sender = Constants.DEFAULT_L2_SENDER (src/L1/OptimismPortal.sol#343)\n",
"type": "node",
"name": "l2Sender = Constants.DEFAULT_L2_SENDER",
"start": 17345,
"length": 38,
"filename_relative": "src/L1/OptimismPortal.sol"
},
{ {
"id": "9ad67b006fc175893dd26d35a020a52dd8524709d87cca61212ee0e147eb992b", "id": "9ad67b006fc175893dd26d35a020a52dd8524709d87cca61212ee0e147eb992b",
"impact": "Medium", "impact": "Medium",
...@@ -1390,5 +1354,41 @@ ...@@ -1390,5 +1354,41 @@
"start": 14329, "start": 14329,
"length": 46, "length": 46,
"filename_relative": "src/universal/CrossDomainMessenger.sol" "filename_relative": "src/universal/CrossDomainMessenger.sol"
},
{
"id": "aba76c5478a36b00ed8b66577c0cd1d3186109cf82c1767ce230c6fe72315c04",
"impact": "Medium",
"confidence": "High",
"check": "write-after-write",
"description": "OptimismPortal.l2Sender (src/L1/OptimismPortal.sol#53) is written in both\n\tl2Sender = _tx.sender (src/L1/OptimismPortal.sol#323)\n\tl2Sender = Constants.DEFAULT_L2_SENDER (src/L1/OptimismPortal.sol#335)\n",
"type": "variable",
"name": "l2Sender",
"start": 2603,
"length": 23,
"filename_relative": "src/L1/OptimismPortal.sol"
},
{
"id": "aba76c5478a36b00ed8b66577c0cd1d3186109cf82c1767ce230c6fe72315c04",
"impact": "Medium",
"confidence": "High",
"check": "write-after-write",
"description": "OptimismPortal.l2Sender (src/L1/OptimismPortal.sol#53) is written in both\n\tl2Sender = _tx.sender (src/L1/OptimismPortal.sol#323)\n\tl2Sender = Constants.DEFAULT_L2_SENDER (src/L1/OptimismPortal.sol#335)\n",
"type": "node",
"name": "l2Sender = _tx.sender",
"start": 16236,
"length": 21,
"filename_relative": "src/L1/OptimismPortal.sol"
},
{
"id": "aba76c5478a36b00ed8b66577c0cd1d3186109cf82c1767ce230c6fe72315c04",
"impact": "Medium",
"confidence": "High",
"check": "write-after-write",
"description": "OptimismPortal.l2Sender (src/L1/OptimismPortal.sol#53) is written in both\n\tl2Sender = _tx.sender (src/L1/OptimismPortal.sol#323)\n\tl2Sender = Constants.DEFAULT_L2_SENDER (src/L1/OptimismPortal.sol#335)\n",
"type": "node",
"name": "l2Sender = Constants.DEFAULT_L2_SENDER",
"start": 17030,
"length": 38,
"filename_relative": "src/L1/OptimismPortal.sol"
} }
] ]
packages/contracts-bedrock/snapshots/abi/OptimismPortal.json
View file @ 731cfea7
...@@ -451,19 +451,6 @@ ...@@ -451,19 +451,6 @@
"name": "Initialized", "name": "Initialized",
"type": "event" "type": "event"
}, },
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "address",
"name": "account",
"type": "address"
}
],
"name": "Paused",
"type": "event"
},
{ {
"anonymous": false, "anonymous": false,
"inputs": [ "inputs": [
...@@ -495,19 +482,6 @@ ...@@ -495,19 +482,6 @@
"name": "TransactionDeposited", "name": "TransactionDeposited",
"type": "event" "type": "event"
}, },
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "address",
"name": "account",
"type": "address"
}
],
"name": "Unpaused",
"type": "event"
},
{ {
"anonymous": false, "anonymous": false,
"inputs": [ "inputs": [
......
packages/contracts-bedrock/src/L1/OptimismPortal.sol
View file @ 731cfea7
...@@ -86,14 +86,6 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver { ...@@ -86,14 +86,6 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver {
/// @param success Whether the withdrawal transaction was successful. /// @param success Whether the withdrawal transaction was successful.
event WithdrawalFinalized(bytes32 indexed withdrawalHash, bool success); event WithdrawalFinalized(bytes32 indexed withdrawalHash, bool success);
/// @notice Emitted when the pause is triggered.
/// @param account Address of the account triggering the pause.
event Paused(address account);
/// @notice Emitted when the pause is lifted.
/// @param account Address of the account triggering the unpause.
event Unpaused(address account);
/// @notice Reverts when paused. /// @notice Reverts when paused.
modifier whenNotPaused() { modifier whenNotPaused() {
require(paused() == false, "OptimismPortal: paused"); require(paused() == false, "OptimismPortal: paused");
...@@ -101,8 +93,8 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver { ...@@ -101,8 +93,8 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver {
} }
/// @notice Semantic version. /// @notice Semantic version.
/// @custom:semver 2.1.0 /// @custom:semver 2.2.0
string public constant version = "2.1.0"; string public constant version = "2.2.0";
/// @notice Constructs the OptimismPortal contract. /// @notice Constructs the OptimismPortal contract.
/// @param _l2Oracle Address of the L2OutputOracle contract. /// @param _l2Oracle Address of the L2OutputOracle contract.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment