Commit 7457c568 authored by clabby's avatar clabby Committed by GitHub

feat(op-challenger): Add `TraceTypeAsteriscKona` to default `--trace-type` option (#13208)

parent 56670a73
......@@ -90,9 +90,9 @@ func TestL1Beacon(t *testing.T) {
func TestTraceType(t *testing.T) {
t.Run("Default", func(t *testing.T) {
expectedDefault := types.TraceTypeCannon
cfg := configForArgs(t, addRequiredArgsExcept(expectedDefault, "--trace-type"))
require.Equal(t, []types.TraceType{expectedDefault}, cfg.TraceTypes)
expectedDefault := []types.TraceType{types.TraceTypeCannon, types.TraceTypeAsteriscKona}
cfg := configForArgs(t, addRequiredArgsForMultipleTracesExcept(expectedDefault, "--trace-type"))
require.Equal(t, expectedDefault, cfg.TraceTypes)
})
for _, traceType := range types.TraceTypes {
......@@ -995,6 +995,12 @@ func addRequiredArgsExcept(traceType types.TraceType, name string, optionalArgs
return append(toArgList(req), optionalArgs...)
}
func addRequiredArgsForMultipleTracesExcept(traceType []types.TraceType, name string, optionalArgs ...string) []string {
req := requiredArgsMultiple(traceType)
delete(req, name)
return append(toArgList(req), optionalArgs...)
}
func addRequiredArgsExceptArr(traceType types.TraceType, names []string, optionalArgs ...string) []string {
req := requiredArgs(traceType)
for _, name := range names {
......@@ -1003,6 +1009,16 @@ func addRequiredArgsExceptArr(traceType types.TraceType, names []string, optiona
return append(toArgList(req), optionalArgs...)
}
func requiredArgsMultiple(traceType []types.TraceType) map[string]string {
args := make(map[string]string)
for _, t := range traceType {
for name, value := range requiredArgs(t) {
args[name] = value
}
}
return args
}
func requiredArgs(traceType types.TraceType) map[string]string {
args := map[string]string{
"--l1-eth-rpc": l1EthRpc,
......
......@@ -65,7 +65,7 @@ var (
Name: "trace-type",
Usage: "The trace types to support. Valid options: " + openum.EnumString(types.TraceTypes),
EnvVars: prefixEnvVars("TRACE_TYPE"),
Value: cli.NewStringSlice(types.TraceTypeCannon.String()),
Value: cli.NewStringSlice(types.TraceTypeCannon.String(), types.TraceTypeAsteriscKona.String()),
}
DatadirFlag = &cli.StringFlag{
Name: "datadir",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment