Commit 799574ff authored by OptimismBot's avatar OptimismBot Committed by GitHub

Merge pull request #5820 from ethereum-optimism/aj/gossip-float

op-node: Preserve topic scores as float64 instead of truncating to uint64
parents f77a83b8 6ebb3aeb
...@@ -143,9 +143,9 @@ func (s *scorer) SnapshotHook() pubsub.ExtendedPeerScoreInspectFn { ...@@ -143,9 +143,9 @@ func (s *scorer) SnapshotHook() pubsub.ExtendedPeerScoreInspectFn {
} }
if topSnap, ok := snap.Topics[blocksTopicName]; ok { if topSnap, ok := snap.Topics[blocksTopicName]; ok {
diff.Blocks.TimeInMesh = float64(topSnap.TimeInMesh) / float64(time.Second) diff.Blocks.TimeInMesh = float64(topSnap.TimeInMesh) / float64(time.Second)
diff.Blocks.MeshMessageDeliveries = uint64(topSnap.MeshMessageDeliveries) diff.Blocks.MeshMessageDeliveries = topSnap.MeshMessageDeliveries
diff.Blocks.FirstMessageDeliveries = uint64(topSnap.FirstMessageDeliveries) diff.Blocks.FirstMessageDeliveries = topSnap.FirstMessageDeliveries
diff.Blocks.InvalidMessageDeliveries = uint64(topSnap.InvalidMessageDeliveries) diff.Blocks.InvalidMessageDeliveries = topSnap.InvalidMessageDeliveries
} }
if err := s.peerStore.SetScore(id, &diff); err != nil { if err := s.peerStore.SetScore(id, &diff); err != nil {
s.log.Warn("Unable to update peer gossip score", "err", err) s.log.Warn("Unable to update peer gossip score", "err", err)
......
...@@ -11,9 +11,9 @@ import ( ...@@ -11,9 +11,9 @@ import (
type TopicScores struct { type TopicScores struct {
TimeInMesh float64 `json:"timeInMesh"` // in seconds TimeInMesh float64 `json:"timeInMesh"` // in seconds
FirstMessageDeliveries uint64 `json:"firstMessageDeliveries"` FirstMessageDeliveries float64 `json:"firstMessageDeliveries"`
MeshMessageDeliveries uint64 `json:"meshMessageDeliveries"` MeshMessageDeliveries float64 `json:"meshMessageDeliveries"`
InvalidMessageDeliveries uint64 `json:"invalidMessageDeliveries"` InvalidMessageDeliveries float64 `json:"invalidMessageDeliveries"`
} }
type GossipScores struct { type GossipScores struct {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment