Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
7b5dfee9
Unverified
Commit
7b5dfee9
authored
Oct 27, 2023
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
docs(ctb): Improved comments in SafeSigners.sol
parent
30377e22
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
8 deletions
+5
-8
SafeSigners.sol
packages/contracts-bedrock/src/Safe/SafeSigners.sol
+5
-8
No files found.
packages/contracts-bedrock/src/Safe/SafeSigners.sol
View file @
7b5dfee9
...
@@ -38,10 +38,11 @@ library SafeSigners {
...
@@ -38,10 +38,11 @@ library SafeSigners {
}
}
/// @notice Extract the signers from a set of signatures.
/// @notice Extract the signers from a set of signatures.
/// @param dataHash Hash of the data.
/// This method is based closely on the code in the Safe.checkNSignatures() method.
/// @param signatures Signature data for identifying signers.
/// https://github.com/safe-global/safe-contracts/blob/e870f514ad34cd9654c72174d6d4a839e3c6639f/contracts/Safe.sol#L274
/// @param requiredSignatures Amount of required valid signatures.
/// It has been modified by removing all signature _validation_ code. We trust the Safe to properly validate
/// @return _owners List of unique signers.
/// the signatures.
/// This method therefore simply extracts the addresses from the signatures.
function getNSigners(
function getNSigners(
bytes32 dataHash,
bytes32 dataHash,
bytes memory signatures,
bytes memory signatures,
...
@@ -53,10 +54,6 @@ library SafeSigners {
...
@@ -53,10 +54,6 @@ library SafeSigners {
{
{
_owners = new address[](requiredSignatures);
_owners = new address[](requiredSignatures);
// The following code is extracted from the Safe.checkNSignatures() method. It removes the signature
// validation code, and keeps only the parsing code necessary to extract the owner addresses from the
// signatures. We do not double check if the owner derived from a signature is valid. As this is handled
// in the final require statement of Safe.checkNSignatures().
address currentOwner;
address currentOwner;
uint8 v;
uint8 v;
bytes32 r;
bytes32 r;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment