Commit 7b7b4856 authored by Maurelian's avatar Maurelian Committed by GitHub

Merge pull request #8478 from ethereum-optimism/ctb/deploy-nonces

contracts-bedrock: be mindful of nonce management
parents e2f819c4 c4100abf
GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_0() (gas: 352278) GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_0() (gas: 352278)
GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_1() (gas: 2950440) GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_1() (gas: 2950440)
GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_0() (gas: 540654) GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_0() (gas: 540648)
GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_1() (gas: 4052847) GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_1() (gas: 4052841)
GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_0() (gas: 442004) GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_0() (gas: 442007)
GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_1() (gas: 3487753) GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_1() (gas: 3487756)
GasBenchMark_L1StandardBridge_Finalize:test_finalizeETHWithdrawal_benchmark() (gas: 55373) GasBenchMark_L1StandardBridge_Finalize:test_finalizeETHWithdrawal_benchmark() (gas: 55367)
GasBenchMark_L2OutputOracle:test_proposeL2Output_benchmark() (gas: 86629) GasBenchMark_L2OutputOracle:test_proposeL2Output_benchmark() (gas: 86629)
GasBenchMark_OptimismPortal:test_depositTransaction_benchmark() (gas: 68462) GasBenchMark_OptimismPortal:test_depositTransaction_benchmark() (gas: 68450)
GasBenchMark_OptimismPortal:test_depositTransaction_benchmark_1() (gas: 68911) GasBenchMark_OptimismPortal:test_depositTransaction_benchmark_1() (gas: 68899)
GasBenchMark_OptimismPortal:test_proveWithdrawalTransaction_benchmark() (gas: 153498) GasBenchMark_OptimismPortal:test_proveWithdrawalTransaction_benchmark() (gas: 153501)
\ No newline at end of file \ No newline at end of file
...@@ -17,7 +17,13 @@ contract CommonTest is Setup, Test, Events { ...@@ -17,7 +17,13 @@ contract CommonTest is Setup, Test, Events {
FFIInterface ffi; FFIInterface ffi;
function setUp() public virtual override { function setUp() public virtual override {
alice = makeAddr("alice");
bob = makeAddr("bob");
vm.deal(alice, 10000 ether);
vm.deal(bob, 10000 ether);
Setup.setUp(); Setup.setUp();
vm.prank(deployer);
ffi = new FFIInterface(); ffi = new FFIInterface();
// Make sure the base fee is non zero // Make sure the base fee is non zero
...@@ -27,11 +33,6 @@ contract CommonTest is Setup, Test, Events { ...@@ -27,11 +33,6 @@ contract CommonTest is Setup, Test, Events {
vm.warp(deploy.cfg().l2OutputOracleStartingTimestamp() + 1); vm.warp(deploy.cfg().l2OutputOracleStartingTimestamp() + 1);
vm.roll(deploy.cfg().l2OutputOracleStartingBlockNumber() + 1); vm.roll(deploy.cfg().l2OutputOracleStartingBlockNumber() + 1);
alice = makeAddr("alice");
bob = makeAddr("bob");
vm.deal(alice, 10000 ether);
vm.deal(bob, 10000 ether);
// Deploy L1 // Deploy L1
Setup.L1(); Setup.L1();
// Deploy L2 // Deploy L2
......
...@@ -41,6 +41,7 @@ contract Setup { ...@@ -41,6 +41,7 @@ contract Setup {
Vm private constant vm = Vm(0x7109709ECfa91a80626fF3989D68f67F5b1DD12D); Vm private constant vm = Vm(0x7109709ECfa91a80626fF3989D68f67F5b1DD12D);
Deploy internal deploy; Deploy internal deploy;
address deployer = address(0xd3607);
OptimismPortal optimismPortal; OptimismPortal optimismPortal;
L2OutputOracle l2OutputOracle; L2OutputOracle l2OutputOracle;
...@@ -80,8 +81,11 @@ contract Setup { ...@@ -80,8 +81,11 @@ contract Setup {
deploy.setUp(); deploy.setUp();
} }
/// @dev Simple wrapper around the `create` opcode /// @dev Simple wrapper around the `create` opcode that uses a particular
/// deployer account.
function _create(bytes memory _code) internal returns (address addr_) { function _create(bytes memory _code) internal returns (address addr_) {
vm.deal(deployer, 1 ether);
vm.prank(deployer);
assembly { assembly {
addr_ := create(0, add(_code, 0x20), mload(_code)) addr_ := create(0, add(_code, 0x20), mload(_code))
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment