feat(kurtosis-devnet): pass args in-memory (#13576)

Now that we don't use the kurtosis cli, there's no reason to go
through the filesystem to pass a configuration file.

kurtosis-devnet/cmd/main.go

@@ -259,7 +259,7 @@ func deploy(ctx context.Context, cfg *config, r io.Reader) error {
 		}
 		defer envOutput.Close()
 	} else {
-		log.Println("Environment description:")
+		log.Println("\nEnvironment description:")
 	}
 
 	enc := json.NewEncoder(envOutput)

kurtosis-devnet/pkg/kurtosis/kurtosis.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"os"
 
 	"github.com/ethereum-optimism/optimism/kurtosis-devnet/pkg/kurtosis/sources/deployer"
 	"github.com/ethereum-optimism/optimism/kurtosis-devnet/pkg/kurtosis/sources/spec"
@@ -130,23 +129,6 @@ func NewKurtosisDeployer(opts ...KurtosisDeployerOptions) *KurtosisDeployer {
 	return d
 }
 
-// prepareArgFile creates a temporary file with the input content and returns its path
-// The caller is responsible for deleting the file.
-func (d *KurtosisDeployer) prepareArgFile(input io.Reader) (string, error) {
-	argFile, err := os.CreateTemp("", "kurtosis-args-*.yaml")
-	if err != nil {
-		return "", fmt.Errorf("failed to create temporary arg file: %w", err)
-	}
-	defer argFile.Close()
-
-	if _, err := io.Copy(argFile, input); err != nil {
-		os.Remove(argFile.Name())
-		return "", fmt.Errorf("failed to write arg file: %w", err)
-	}
-
-	return argFile.Name(), nil
-}
-
 func (d *KurtosisDeployer) getWallets(wallets deployer.WalletList) WalletMap {
 	walletMap := make(WalletMap)
 	for _, wallet := range wallets {
@@ -219,15 +201,8 @@ func (d *KurtosisDeployer) Deploy(ctx context.Context, input io.Reader) (*Kurtos
 		return nil, fmt.Errorf("failed to parse input spec: %w", err)
 	}
 
-	// Prepare argument file
-	argFile, err := d.prepareArgFile(inputCopy)
-	if err != nil {
-		return nil, err
-	}
-	defer os.Remove(argFile)
-
 	// Run kurtosis command
-	if err := d.runKurtosis(ctx, argFile); err != nil {
+	if err := d.runKurtosis(ctx, inputCopy); err != nil {
 		return nil, err
 	}
 

kurtosis-devnet/pkg/kurtosis/kurtosis_run.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"io"
 	"os"
 
 	"github.com/fatih/color"
@@ -374,10 +375,17 @@ func (w *instructionResultWrapper) GetSerializedInstructionResult() string {
 }
 
 // runKurtosis executes the kurtosis package using the SDK
-func (d *KurtosisDeployer) runKurtosis(ctx context.Context, argFile string) error {
+func (d *KurtosisDeployer) runKurtosis(ctx context.Context, args io.Reader) error {
 	if d.dryRun {
-		fmt.Printf("Dry run mode enabled, would run kurtosis package %s with args file %s in enclave %s\n",
-			d.packageName, argFile, d.enclave)
+		fmt.Printf("Dry run mode enabled, would run kurtosis package %s in enclave %s\n",
+			d.packageName, d.enclave)
+		if args != nil {
+			fmt.Println("\nWith arguments:")
+			if _, err := io.Copy(os.Stdout, args); err != nil {
+				return fmt.Errorf("failed to dump args: %w", err)
+			}
+			fmt.Println()
+		}
 		return nil
 	}
 
@@ -405,11 +413,12 @@ func (d *KurtosisDeployer) runKurtosis(ctx context.Context, argFile string) erro
 		fmt.Printf("Using existing enclave '%s'\n\n", d.enclave)
 	}
 
+	// Set up run config with args if provided
 	var serializedParams string
-	if argFile != "" {
-		argsBytes, err := os.ReadFile(argFile)
+	if args != nil {
+		argsBytes, err := io.ReadAll(args)
 		if err != nil {
-			return fmt.Errorf("failed to read args file: %w", err)
+			return fmt.Errorf("failed to read args: %w", err)
 		}
 		serializedParams = string(argsBytes)
 	}

kurtosis-devnet/pkg/kurtosis/kurtosis_run_test.go

@@ -261,7 +261,7 @@ func TestRunKurtosis(t *testing.T) {
 			d := NewKurtosisDeployer()
 			d.kurtosisCtx = fakeCtx
 
-			err := d.runKurtosis(ctx, "")
+			err := d.runKurtosis(ctx, nil)
 			if tt.wantErr {
 				assert.Error(t, err)
 			} else {

kurtosis-devnet/pkg/kurtosis/kurtosis_test.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"os"
 	"strings"
 	"testing"
 
@@ -58,22 +57,6 @@ func TestKurtosisDeployer(t *testing.T) {
 	}
 }
 
-func TestPrepareArgFile(t *testing.T) {
-	d := NewKurtosisDeployer()
-	input := strings.NewReader("test content")
-
-	path, err := d.prepareArgFile(input)
-	require.NoError(t, err)
-	defer func() {
-		err := os.Remove(path)
-		require.NoError(t, err)
-	}()
-
-	content, err := os.ReadFile(path)
-	require.NoError(t, err)
-	assert.Equal(t, "test content", string(content))
-}
-
 // fakeEnclaveInspecter implements EnclaveInspecter for testing
 type fakeEnclaveInspecter struct {
 	result *inspect.InspectData