Merge pull request #6472 from ethereum-optimism/ci/op-bindings-faster

op-bindings: make ci faster

.circleci/config.yml

@@ -110,7 +110,7 @@ jobs:
     steps:
       - checkout
       - check-changed:
-          patterns: op-bindings,op-chain-ops,packages/
+          patterns: op-chain-ops,packages/
       - restore_cache:
           name: Restore PNPM Package Cache
           keys:
@@ -554,26 +554,6 @@ jobs:
     resource_class: medium
     steps:
       - checkout
-      - attach_workspace: { at: "." }
-      - restore_cache:
-          name: Restore PNPM Package Cache
-          keys:
-            - pnpm-packages-v2-{{ checksum "pnpm-lock.yaml" }}
-      - check-changed:
-          patterns: contracts-bedrock,op-bindings
-      # TODO remove me after ci builder updated
-      - run:
-          name: Install pnpm package manager
-          command: |
-            npm i pnpm --global
-      # TODO remove me after ci builder updated
-      # A github dep clones-with-immutable-args is installed via github
-      # packages installed via npm via github automatically run postpack scripts
-      # their postpack script happens to use yarn so we need it here
-      - run:
-          name: Install yarn package manager
-          command: |
-            npm i yarn@1 --global
       - run:
           name: check go bindings
           command: make && git diff --exit-code
@@ -1274,9 +1254,7 @@ workflows:
       - contracts-bedrock-validate-spaces:
           requires:
             - pnpm-monorepo
-      - op-bindings-build:
-          requires:
-            - pnpm-monorepo
+      - op-bindings-build
       - js-lint-test:
           name: chain-mon-tests
           coverage_flag: chain-mon-tests

op-bindings/README.md

@@ -9,6 +9,12 @@ can deploy the contracts. There are also `more` files that include the deployed
 bytecode as well as the storage layout. These are used to dynamically set
 bytecode and storage slots in state.
 
+## Usage
+
+```bash
+make
+```
+
 ## Dependencies
 
 - `abigen` version 1.10.25

packages/contracts-bedrock/package.json

@@ -12,10 +12,8 @@
     "bindings": "pnpm bindings:ts && pnpm bindings:go",
     "bindings:ts": "pnpm generate:addresses && nx generate @eth-optimism/contracts-ts",
     "bindings:go": "cd ../../op-bindings && make",
-    "build": "nx build:contracts",
-    "prebuild:contracts": "./scripts/verify-foundry-install.sh",
-    "build:contracts": "pnpm build:forge",
-    "build:forge": "forge build",
+    "build": "forge build",
+    "prebuild": "./scripts/verify-foundry-install.sh",
     "build:differential": "go build -o ./scripts/differential-testing/differential-testing ./scripts/differential-testing",
     "build:fuzz": "(cd test-case-generator && go build ./cmd/fuzz.go)",
     "autogen:invariant-docs": "ts-node scripts/invariant-doc-gen.ts",
@@ -26,7 +24,7 @@
     "storage-snapshot": "./scripts/storage-snapshot.sh",
     "semver-lock": "forge script scripts/SemverLock.s.sol",
     "validate-deploy-configs": "./scripts/validate-deploy-configs.sh",
-    "validate-spacers": "forge build && npx ts-node scripts/validate-spacers.ts",
+    "validate-spacers": "pnpm build && npx ts-node scripts/validate-spacers.ts",
     "slither": "./scripts/slither.sh",
     "slither:triage": "TRIAGE_MODE=1 ./scripts/slither.sh",
     "clean": "rm -rf ./dist ./artifacts ./forge-artifacts ./cache ./tsconfig.tsbuildinfo ./tsconfig.build.tsbuildinfo ./src/contract-artifacts.ts ./test-case-generator/fuzz",