Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
82108382
Commit
82108382
authored
Jun 01, 2022
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
contracts: Fix OZ-L-05 Warn about trapped funds
parent
53e3104a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
3 deletions
+9
-3
L1StandardBridge.sol
packages/contracts-bedrock/contracts/L1/L1StandardBridge.sol
+3
-1
L2StandardBridge.sol
packages/contracts-bedrock/contracts/L2/L2StandardBridge.sol
+4
-1
StandardBridge.sol
.../contracts-bedrock/contracts/universal/StandardBridge.sol
+2
-1
No files found.
packages/contracts-bedrock/contracts/L1/L1StandardBridge.sol
View file @
82108382
...
...
@@ -118,7 +118,9 @@ contract L1StandardBridge is StandardBridge {
/**
* @custom:legacy
* @notice Deposits some amount of ETH into a target account on L2.
* @notice Deposits some amount of ETH into a target account on L2. Note that if ETH is sent to
* a contract on L2 and the call fails, then that ETH will be locked in the
* L2StandardBridge.
*
* @param _to Address of the recipient on L2.
* @param _minGasLimit Minimum gas limit for the deposit message on L2.
...
...
packages/contracts-bedrock/contracts/L2/L2StandardBridge.sol
View file @
82108382
...
...
@@ -106,7 +106,9 @@ contract L2StandardBridge is StandardBridge {
/**
* @custom:legacy
* @notice Initiates a withdrawal from L2 to L1 to a target account on L1.
* @notice Initiates a withdrawal from L2 to L1 to a target account on L1. Note that if ETH is
* sent to a contract on L1 and the call fails, then that ETH will be locked in the
* L1StandardBridge.
*
* @param _l2Token Address of the L2 token to withdraw.
* @param _to Recipient account on L1.
...
...
@@ -121,6 +123,7 @@ contract L2StandardBridge is StandardBridge {
uint32 _minGasLimit,
bytes calldata _data
) external payable virtual {
// TODO: add onlyEOA check on ETH withdrawals to match L1Bridge.depositETHTo?
_initiateWithdrawal(_l2Token, msg.sender, _to, _amount, _minGasLimit, _data);
}
...
...
packages/contracts-bedrock/contracts/universal/StandardBridge.sol
View file @
82108382
...
...
@@ -139,7 +139,8 @@ abstract contract StandardBridge {
}
/**
* @notice Send ETH to a specified account on the remote domain
* @notice Send ETH to a specified account on the remote domain. Note that if ETH is sent to a
* contract and the call fails, then that ETH will be locked in the other bridge.
*/
function bridgeETHTo(
address _to,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment