Merge pull request #4399 from ethereum-optimism/jm/solc-warning

ctb: Fix linter warnings in echidna contracts

packages/contracts-bedrock/.solhint.json

@@ -7,6 +7,7 @@
     "code-complexity": ["warn", 5],
     "max-line-length": ["error", 100],
     "func-param-name-mixedcase": "error",
+    "func-name-mixedcase": "off",
     "modifier-name-mixedcase": "error",
     "ordering": "warn",
     "avoid-low-level-calls": "off",

packages/contracts-bedrock/contracts/echidna/FuzzAddressAliasing.sol

@@ -3,7 +3,7 @@ pragma solidity 0.8.15;
 import { AddressAliasHelper } from "../vendor/AddressAliasHelper.sol";
 
 contract EchidnaFuzzAddressAliasing {
-    bool failedRoundtrip;
+    bool internal failedRoundtrip;
 
     /**
      * @notice Takes an address to be aliased with AddressAliasHelper and then unaliased

packages/contracts-bedrock/contracts/echidna/FuzzBurn.sol

@@ -4,7 +4,7 @@ import { Burn } from "../libraries/Burn.sol";
 import { StdUtils } from "forge-std/Test.sol";
 
 contract EchidnaFuzzBurnEth is StdUtils {
-    bool failedEthBurn;
+    bool internal failedEthBurn;
 
     /**
      * @notice Takes an integer amount of eth to burn through the Burn library and
@@ -33,7 +33,7 @@ contract EchidnaFuzzBurnEth is StdUtils {
 }
 
 contract EchidnaFuzzBurnGas is StdUtils {
-    bool failedGasBurn;
+    bool internal failedGasBurn;
 
     /**
      * @notice Takes an integer amount of gas to burn through the Burn library and

packages/contracts-bedrock/contracts/echidna/FuzzEncoding.sol

@@ -3,8 +3,8 @@ pragma solidity 0.8.15;
 import { Encoding } from "../libraries/Encoding.sol";
 
 contract EchidnaFuzzEncoding {
-    bool failedRoundtripAToB;
-    bool failedRoundtripBToA;
+    bool internal failedRoundtripAToB;
+    bool internal failedRoundtripBToA;
 
     /**
      * @notice Takes a pair of integers to be encoded into a versioned nonce with the

packages/contracts-bedrock/contracts/echidna/FuzzHashing.sol

@@ -4,9 +4,9 @@ import { Hashing } from "../libraries/Hashing.sol";
 import { Encoding } from "../libraries/Encoding.sol";
 
 contract EchidnaFuzzHashing {
-    bool failedCrossDomainHashHighVersion;
-    bool failedCrossDomainHashV0;
-    bool failedCrossDomainHashV1;
+    bool internal failedCrossDomainHashHighVersion;
+    bool internal failedCrossDomainHashV0;
+    bool internal failedCrossDomainHashV1;
 
     /**
      * @notice Takes the necessary parameters to perform a cross domain hash with a randomly

packages/contracts-bedrock/contracts/echidna/FuzzResourceMetering.sol

@@ -5,16 +5,16 @@ import { Arithmetic } from "../libraries/Arithmetic.sol";
 import { StdUtils } from "forge-std/Test.sol";
 
 contract EchidnaFuzzResourceMetering is ResourceMetering, StdUtils {
-    bool failedMaxGasPerBlock;
-    bool failedRaiseBaseFee;
-    bool failedLowerBaseFee;
-    bool failedNeverBelowMinBaseFee;
-    bool failedMaxRaiseBaseFeePerBlock;
-    bool failedMaxLowerBaseFeePerBlock;
+    bool internal failedMaxGasPerBlock;
+    bool internal failedRaiseBaseFee;
+    bool internal failedLowerBaseFee;
+    bool internal failedNeverBelowMinBaseFee;
+    bool internal failedMaxRaiseBaseFeePerBlock;
+    bool internal failedMaxLowerBaseFeePerBlock;
 
     // Used as a special flag for the purpose of identifying unchecked math errors specifically
     // in the test contracts, not the target contracts themselves.
-    bool underflow;
+    bool internal underflow;
 
     constructor() {
         initialize();