contracts-bedrock: fix deploy utils

It is possible for the backend to prune the chain db which
will cause `waitForTransaction` to hang forever if the contract
was not recently deployed. Only check for the transaction if
it was recently deployed and instead add a safety check that
looks at the on chain code. It is unlikely to deploy a contract that
leaves no code in the state, so this is safe. The state cannot
be pruned so this will be a more reliable check to ensure that
the deployment is sane and exists. We do not use selfdestruct
so this is safe.

packages/contracts-bedrock/src/deploy-utils.ts

@@ -54,10 +54,16 @@ export const deploy = async ({
       waitConfirmations: hre.deployConfig.numDeployConfirmations,
     })
     console.log(`Deployed ${name} at ${result.address}`)
+    // Only wait for the transaction if it was recently deployed in case the
+    // result was deployed a long time ago and was pruned from the backend.
+    await hre.ethers.provider.waitForTransaction(result.transactionHash)
   }
 
-  // Always wait for the transaction to be mined, just in case.
-  await hre.ethers.provider.waitForTransaction(result.transactionHash)
+  // Check to make sure there is code
+  const code = await hre.ethers.provider.getCode(result.address)
+  if (code === '0x') {
+    throw new Error(`no code for ${result.address}`)
+  }
 
   // Create the contract object to return.
   const created = asAdvancedContract({