Commit 85c9a9ea authored by Michael Amadi's avatar Michael Amadi Committed by GitHub

fix test name checks (#12880)

parent 8df2b1d5
...@@ -119,7 +119,7 @@ contract PreinstallsTest is CommonTest { ...@@ -119,7 +119,7 @@ contract PreinstallsTest is CommonTest {
assertPreinstall(Preinstalls.CreateX, Preinstalls.CreateXCode); assertPreinstall(Preinstalls.CreateX, Preinstalls.CreateXCode);
} }
function test_createX_runtimeBytecodeHash() external view { function test_createX_runtimeBytecodeHash_works() external view {
bytes memory createXRuntimeBytecode = Preinstalls.CreateX.code; bytes memory createXRuntimeBytecode = Preinstalls.CreateX.code;
bytes32 createXRuntimeBytecodeHash = keccak256(createXRuntimeBytecode); bytes32 createXRuntimeBytecodeHash = keccak256(createXRuntimeBytecode);
......
...@@ -125,7 +125,7 @@ contract SuperchainERC20Test is Test { ...@@ -125,7 +125,7 @@ contract SuperchainERC20Test is Test {
/// @notice Tests that the `supportsInterface` function returns false for any other interface than the /// @notice Tests that the `supportsInterface` function returns false for any other interface than the
/// `IERC7802` one. /// `IERC7802` one.
function testFuzz_supportInterface_returnFalse(bytes4 _interfaceId) public view { function testFuzz_supportInterface_works(bytes4 _interfaceId) public view {
vm.assume(_interfaceId != type(IERC165).interfaceId); vm.assume(_interfaceId != type(IERC165).interfaceId);
vm.assume(_interfaceId != type(IERC7802).interfaceId); vm.assume(_interfaceId != type(IERC7802).interfaceId);
vm.assume(_interfaceId != type(IERC20).interfaceId); vm.assume(_interfaceId != type(IERC20).interfaceId);
......
...@@ -469,7 +469,7 @@ contract SuperchainWETH_Test is CommonTest { ...@@ -469,7 +469,7 @@ contract SuperchainWETH_Test is CommonTest {
/// @notice Tests that the `supportsInterface` function returns false for any other interface than the /// @notice Tests that the `supportsInterface` function returns false for any other interface than the
/// `IERC7802` one. /// `IERC7802` one.
function testFuzz_supportInterface_returnFalse(bytes4 _interfaceId) public view { function testFuzz_supportInterface_works(bytes4 _interfaceId) public view {
vm.assume(_interfaceId != type(IERC165).interfaceId); vm.assume(_interfaceId != type(IERC165).interfaceId);
vm.assume(_interfaceId != type(IERC7802).interfaceId); vm.assume(_interfaceId != type(IERC7802).interfaceId);
vm.assume(_interfaceId != type(IERC20).interfaceId); vm.assume(_interfaceId != type(IERC20).interfaceId);
......
...@@ -44,7 +44,7 @@ contract DeployAltDAInput_Test is Test { ...@@ -44,7 +44,7 @@ contract DeployAltDAInput_Test is Test {
assertEq(resolverRefundPercentage, dai.resolverRefundPercentage(), "700"); assertEq(resolverRefundPercentage, dai.resolverRefundPercentage(), "700");
} }
function test_getters_whenNotSet_revert() public { function test_getters_whenNotSet_reverts() public {
bytes memory expectedErr = "DeployAltDAInput: "; bytes memory expectedErr = "DeployAltDAInput: ";
vm.expectRevert(abi.encodePacked(expectedErr, "salt not set")); vm.expectRevert(abi.encodePacked(expectedErr, "salt not set"));
...@@ -119,7 +119,7 @@ contract DeployAltDAOutput_Test is Test { ...@@ -119,7 +119,7 @@ contract DeployAltDAOutput_Test is Test {
assertEq(address(dataAvailabilityChallengeImpl), address(dao.dataAvailabilityChallengeImpl()), "200"); assertEq(address(dataAvailabilityChallengeImpl), address(dao.dataAvailabilityChallengeImpl()), "200");
} }
function test_getters_whenNotSet_revert() public { function test_getters_whenNotSet_reverts() public {
vm.expectRevert("DeployUtils: zero address"); vm.expectRevert("DeployUtils: zero address");
dao.dataAvailabilityChallengeProxy(); dao.dataAvailabilityChallengeProxy();
...@@ -231,7 +231,7 @@ contract DeployAltDA_Test is Test { ...@@ -231,7 +231,7 @@ contract DeployAltDA_Test is Test {
deployer.checkOutput(dai, dao); deployer.checkOutput(dai, dao);
} }
function testFuzz_run_withDifferentParameters( function testFuzz_run_withDifferentParameters_works(
uint256 _challengeWindow, uint256 _challengeWindow,
uint256 _resolveWindow, uint256 _resolveWindow,
uint256 _bondSize, uint256 _bondSize,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment