Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
8ed8be88
Unverified
Commit
8ed8be88
authored
Dec 05, 2023
by
refcell.eth
Committed by
GitHub
Dec 05, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #8433 from ethereum-optimism/aj/remove-todo
FaultDisputeGame: Remove TODO
parents
2e647210
ddb2f3ea
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
6 additions
and
9 deletions
+6
-9
faultdisputegame.go
op-bindings/bindings/faultdisputegame.go
+1
-1
faultdisputegame_more.go
op-bindings/bindings/faultdisputegame_more.go
+1
-1
semver-lock.json
packages/contracts-bedrock/semver-lock.json
+2
-2
FaultDisputeGame.sol
packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
+2
-5
No files found.
op-bindings/bindings/faultdisputegame.go
View file @
8ed8be88
This diff is collapsed.
Click to expand it.
op-bindings/bindings/faultdisputegame_more.go
View file @
8ed8be88
This diff is collapsed.
Click to expand it.
packages/contracts-bedrock/semver-lock.json
View file @
8ed8be88
...
...
@@ -96,8 +96,8 @@
"sourceCodeHash"
:
"0x64290a5d8138c46d2ecd308e3ef62ba04663049cce8a271b9a686ddd2e630391"
},
"src/dispute/FaultDisputeGame.sol"
:
{
"initCodeHash"
:
"0x
c4c2fe17a1e9c82c924b0ac3dbd6512850a19b55125eca14c2636cc4adb9cc67
"
,
"sourceCodeHash"
:
"0x
1d0cacaf259aff7802aae91a793e3c7234a4d063614cf9c72176fb04738e7c97
"
"initCodeHash"
:
"0x
77ae981180b9c2fc9cf33b7862551f74368e8889f68c2f535f46730d1272eba3
"
,
"sourceCodeHash"
:
"0x
a995b54dce03ddf5c9c47451bd7181996b91398ad66b54ab0b8cbf582863a33e
"
},
"src/dispute/OutputBisectionGame.sol"
:
{
"initCodeHash"
:
"0x400a99278755979b815712d1d26598463dd98ed193df8cd1736ae2ae5831d7c7"
,
...
...
packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
View file @
8ed8be88
...
...
@@ -82,8 +82,8 @@ contract FaultDisputeGame is IFaultDisputeGame, Clone, ISemver {
bool internal subgameAtRootResolved;
/// @notice Semantic version.
/// @custom:semver 0.0.1
2
string public constant version = "0.0.1
2
";
/// @custom:semver 0.0.1
3
string public constant version = "0.0.1
3
";
/// @param _gameType The type ID of the game.
/// @param _absolutePrestate The absolute prestate of the instruction trace.
...
...
@@ -174,9 +174,6 @@ contract FaultDisputeGame is IFaultDisputeGame, Clone, ISemver {
// SAFETY: While the `attack` path does not need an extra check for the post
// state's depth in relation to the parent, we don't need another
// branch because (n - n) % 2 == 0.
// TODO(client-pod#94): Once output bisection is implemented, the local context will no longer
// be constant. We will need to pass it in here based off of the ancestor
// disputed output root's L2 block number.
bool validStep = VM.step(_stateData, _proof, 0) == Claim.unwrap(postState.claim);
bool parentPostAgree = (parentPos.depth() - postState.position.depth()) % 2 == 0;
if (parentPostAgree == validStep) revert ValidStep();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment