Commit 8f91dde3 authored by coolhill's avatar coolhill

single-line slither-disable, better-looking

parent 44655464
...@@ -199,9 +199,7 @@ contract L1CrossDomainMessenger is ...@@ -199,9 +199,7 @@ contract L1CrossDomainMessenger is
); );
xDomainMsgSender = _sender; xDomainMsgSender = _sender;
// slither-disable-next-line reentrancy-no-eth // slither-disable-next-line reentrancy-no-eth, reentrancy-events, reentrancy-benign
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
(bool success, ) = _target.call(_message); (bool success, ) = _target.call(_message);
// slither-disable-next-line reentrancy-benign // slither-disable-next-line reentrancy-benign
xDomainMsgSender = Lib_DefaultValues.DEFAULT_XDOMAIN_SENDER; xDomainMsgSender = Lib_DefaultValues.DEFAULT_XDOMAIN_SENDER;
......
...@@ -183,8 +183,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled { ...@@ -183,8 +183,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled {
// When a deposit is initiated on L1, the L1 Bridge transfers the funds to itself for future // When a deposit is initiated on L1, the L1 Bridge transfers the funds to itself for future
// withdrawals. safeTransferFrom also checks if the contract has code, so this will fail if // withdrawals. safeTransferFrom also checks if the contract has code, so this will fail if
// _from is an EOA or address(0). // _from is an EOA or address(0).
// slither-disable-next-line reentrancy-events // slither-disable-next-line reentrancy-events, reentrancy-benign
// slither-disable-next-line reentrancy-benign
IERC20(_l1Token).safeTransferFrom(_from, address(this), _amount); IERC20(_l1Token).safeTransferFrom(_from, address(this), _amount);
// Construct calldata for _l2Token.finalizeDeposit(_to, _amount) // Construct calldata for _l2Token.finalizeDeposit(_to, _amount)
...@@ -199,8 +198,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled { ...@@ -199,8 +198,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled {
); );
// Send calldata into L2 // Send calldata into L2
// slither-disable-next-line reentrancy-events // slither-disable-next-line reentrancy-events, reentrancy-benign
// slither-disable-next-line reentrancy-benign
sendCrossDomainMessage(l2TokenBridge, _l2Gas, message); sendCrossDomainMessage(l2TokenBridge, _l2Gas, message);
// slither-disable-next-line reentrancy-benign // slither-disable-next-line reentrancy-benign
......
...@@ -358,8 +358,7 @@ contract CanonicalTransactionChain is ICanonicalTransactionChain, Lib_AddressRes ...@@ -358,8 +358,7 @@ contract CanonicalTransactionChain is ICanonicalTransactionChain, Lib_AddressRes
} }
// Cache the previous blockhash to ensure all transaction data can be retrieved efficiently. // Cache the previous blockhash to ensure all transaction data can be retrieved efficiently.
// slither-disable-next-line reentrancy-no-eth // slither-disable-next-line reentrancy-no-eth, reentrancy-events
// slither-disable-next-line reentrancy-events
_appendBatch( _appendBatch(
blockhash(block.number - 1), blockhash(block.number - 1),
totalElementsToAppend, totalElementsToAppend,
...@@ -528,8 +527,7 @@ contract CanonicalTransactionChain is ICanonicalTransactionChain, Lib_AddressRes ...@@ -528,8 +527,7 @@ contract CanonicalTransactionChain is ICanonicalTransactionChain, Lib_AddressRes
_blockNumber _blockNumber
); );
// slither-disable-next-line reentrancy-no-eth // slither-disable-next-line reentrancy-no-eth, reentrancy-events
// slither-disable-next-line reentrancy-events
batchesRef.push(batchHeaderHash, latestBatchContext); batchesRef.push(batchHeaderHash, latestBatchContext);
} }
} }
...@@ -72,8 +72,7 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger { ...@@ -72,8 +72,7 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
sentMessages[keccak256(xDomainCalldata)] = true; sentMessages[keccak256(xDomainCalldata)] = true;
// Actually send the message. // Actually send the message.
// slither-disable-next-line reentrancy-no-eth // slither-disable-next-line reentrancy-no-eth, reentrancy-events
// slither-disable-next-line reentrancy-events
iOVM_L2ToL1MessagePasser(Lib_PredeployAddresses.L2_TO_L1_MESSAGE_PASSER).passMessageToL1( iOVM_L2ToL1MessagePasser(Lib_PredeployAddresses.L2_TO_L1_MESSAGE_PASSER).passMessageToL1(
xDomainCalldata xDomainCalldata
); );
...@@ -125,9 +124,7 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger { ...@@ -125,9 +124,7 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
} }
xDomainMsgSender = _sender; xDomainMsgSender = _sender;
// slither-disable-next-line reentrancy-no-eth // slither-disable-next-line reentrancy-no-eth, reentrancy-events, reentrancy-benign
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
(bool success, ) = _target.call(_message); (bool success, ) = _target.call(_message);
// slither-disable-next-line reentrancy-benign // slither-disable-next-line reentrancy-benign
xDomainMsgSender = Lib_DefaultValues.DEFAULT_XDOMAIN_SENDER; xDomainMsgSender = Lib_DefaultValues.DEFAULT_XDOMAIN_SENDER;
......
...@@ -77,8 +77,7 @@ contract CrossDomainEnabled { ...@@ -77,8 +77,7 @@ contract CrossDomainEnabled {
uint32 _gasLimit, uint32 _gasLimit,
bytes memory _message bytes memory _message
) internal { ) internal {
// slither-disable-next-line reentrancy-events // slither-disable-next-line reentrancy-events, reentrancy-benign
// slither-disable-next-line reentrancy-benign
getCrossDomainMessenger().sendMessage(_crossDomainTarget, _message, _gasLimit); getCrossDomainMessenger().sendMessage(_crossDomainTarget, _message, _gasLimit);
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment