Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
8f91dde3
Commit
8f91dde3
authored
Nov 30, 2021
by
coolhill
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
single-line slither-disable, better-looking
parent
44655464
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
18 deletions
+8
-18
L1CrossDomainMessenger.sol
...ntracts/contracts/L1/messaging/L1CrossDomainMessenger.sol
+1
-3
L1StandardBridge.sol
...ges/contracts/contracts/L1/messaging/L1StandardBridge.sol
+2
-4
CanonicalTransactionChain.sol
...ntracts/contracts/L1/rollup/CanonicalTransactionChain.sol
+2
-4
L2CrossDomainMessenger.sol
...ntracts/contracts/L2/messaging/L2CrossDomainMessenger.sol
+2
-5
CrossDomainEnabled.sol
...ntracts/contracts/libraries/bridge/CrossDomainEnabled.sol
+1
-2
No files found.
packages/contracts/contracts/L1/messaging/L1CrossDomainMessenger.sol
View file @
8f91dde3
...
...
@@ -199,9 +199,7 @@ contract L1CrossDomainMessenger is
);
xDomainMsgSender = _sender;
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
// slither-disable-next-line reentrancy-no-eth, reentrancy-events, reentrancy-benign
(bool success, ) = _target.call(_message);
// slither-disable-next-line reentrancy-benign
xDomainMsgSender = Lib_DefaultValues.DEFAULT_XDOMAIN_SENDER;
...
...
packages/contracts/contracts/L1/messaging/L1StandardBridge.sol
View file @
8f91dde3
...
...
@@ -183,8 +183,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled {
// When a deposit is initiated on L1, the L1 Bridge transfers the funds to itself for future
// withdrawals. safeTransferFrom also checks if the contract has code, so this will fail if
// _from is an EOA or address(0).
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
// slither-disable-next-line reentrancy-events, reentrancy-benign
IERC20(_l1Token).safeTransferFrom(_from, address(this), _amount);
// Construct calldata for _l2Token.finalizeDeposit(_to, _amount)
...
...
@@ -199,8 +198,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled {
);
// Send calldata into L2
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
// slither-disable-next-line reentrancy-events, reentrancy-benign
sendCrossDomainMessage(l2TokenBridge, _l2Gas, message);
// slither-disable-next-line reentrancy-benign
...
...
packages/contracts/contracts/L1/rollup/CanonicalTransactionChain.sol
View file @
8f91dde3
...
...
@@ -358,8 +358,7 @@ contract CanonicalTransactionChain is ICanonicalTransactionChain, Lib_AddressRes
}
// Cache the previous blockhash to ensure all transaction data can be retrieved efficiently.
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-no-eth, reentrancy-events
_appendBatch(
blockhash(block.number - 1),
totalElementsToAppend,
...
...
@@ -528,8 +527,7 @@ contract CanonicalTransactionChain is ICanonicalTransactionChain, Lib_AddressRes
_blockNumber
);
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-no-eth, reentrancy-events
batchesRef.push(batchHeaderHash, latestBatchContext);
}
}
packages/contracts/contracts/L2/messaging/L2CrossDomainMessenger.sol
View file @
8f91dde3
...
...
@@ -72,8 +72,7 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
sentMessages[keccak256(xDomainCalldata)] = true;
// Actually send the message.
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-no-eth, reentrancy-events
iOVM_L2ToL1MessagePasser(Lib_PredeployAddresses.L2_TO_L1_MESSAGE_PASSER).passMessageToL1(
xDomainCalldata
);
...
...
@@ -125,9 +124,7 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
}
xDomainMsgSender = _sender;
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
// slither-disable-next-line reentrancy-no-eth, reentrancy-events, reentrancy-benign
(bool success, ) = _target.call(_message);
// slither-disable-next-line reentrancy-benign
xDomainMsgSender = Lib_DefaultValues.DEFAULT_XDOMAIN_SENDER;
...
...
packages/contracts/contracts/libraries/bridge/CrossDomainEnabled.sol
View file @
8f91dde3
...
...
@@ -77,8 +77,7 @@ contract CrossDomainEnabled {
uint32 _gasLimit,
bytes memory _message
) internal {
// slither-disable-next-line reentrancy-events
// slither-disable-next-line reentrancy-benign
// slither-disable-next-line reentrancy-events, reentrancy-benign
getCrossDomainMessenger().sendMessage(_crossDomainTarget, _message, _gasLimit);
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment