Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
92d675b5
Unverified
Commit
92d675b5
authored
Sep 02, 2021
by
elenadimitrova
Committed by
Kelvin Fichter
Nov 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Switch using encoded message and use decoded message from event
parent
3b937854
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
37 additions
and
27 deletions
+37
-27
OVM_L1CrossDomainMessenger.sol
...cts/contracts/L1/messaging/OVM_L1CrossDomainMessenger.sol
+1
-1
OVM_L2CrossDomainMessenger.sol
...cts/contracts/L2/messaging/OVM_L2CrossDomainMessenger.sol
+1
-1
iOVM_CrossDomainMessenger.sol
.../contracts/libraries/bridge/iOVM_CrossDomainMessenger.sol
+6
-1
watcher.ts
packages/core-utils/src/watcher.ts
+4
-3
relay-tx.ts
packages/message-relayer/src/relay-tx.ts
+4
-10
service.ts
packages/message-relayer/src/service.ts
+14
-10
MockL2CrossDomainMessenger.sol
...elayer/test/test-contracts/MockL2CrossDomainMessenger.sol
+7
-1
No files found.
packages/contracts/contracts/L1/messaging/OVM_L1CrossDomainMessenger.sol
View file @
92d675b5
...
@@ -212,7 +212,7 @@ contract OVM_L1CrossDomainMessenger is
...
@@ -212,7 +212,7 @@ contract OVM_L1CrossDomainMessenger is
_gasLimit
_gasLimit
);
);
emit SentMessage(_target, _message, nonce, _gasLimit);
emit SentMessage(_target,
msg.sender,
_message, nonce, _gasLimit);
}
}
/**
/**
...
...
packages/contracts/contracts/L2/messaging/OVM_L2CrossDomainMessenger.sol
View file @
92d675b5
...
@@ -102,7 +102,7 @@ contract OVM_L2CrossDomainMessenger is
...
@@ -102,7 +102,7 @@ contract OVM_L2CrossDomainMessenger is
sentMessages[keccak256(xDomainCalldata)] = true;
sentMessages[keccak256(xDomainCalldata)] = true;
_sendXDomainMessage(xDomainCalldata, _gasLimit);
_sendXDomainMessage(xDomainCalldata, _gasLimit);
emit SentMessage(_target, _message, messageNonce, _gasLimit);
emit SentMessage(_target,
msg.sender,
_message, messageNonce, _gasLimit);
}
}
/**
/**
...
...
packages/contracts/contracts/libraries/bridge/iOVM_CrossDomainMessenger.sol
View file @
92d675b5
...
@@ -11,7 +11,12 @@ interface iOVM_CrossDomainMessenger {
...
@@ -11,7 +11,12 @@ interface iOVM_CrossDomainMessenger {
* Events *
* Events *
**********/
**********/
event SentMessage(address indexed target, bytes message, uint256 messageNonce, uint256 gasLimit);
event SentMessage(
address indexed target,
address sender,
bytes message,
uint256 messageNonce,
uint256 gasLimit);
event RelayedMessage(bytes32 indexed msgHash);
event RelayedMessage(bytes32 indexed msgHash);
event FailedRelayedMessage(bytes32 indexed msgHash);
event FailedRelayedMessage(bytes32 indexed msgHash);
...
...
packages/core-utils/src/watcher.ts
View file @
92d675b5
...
@@ -75,10 +75,11 @@ export class Watcher {
...
@@ -75,10 +75,11 @@ export class Watcher {
for
(
const
log
of
receipt
.
logs
)
{
for
(
const
log
of
receipt
.
logs
)
{
if
(
if
(
log
.
address
===
layer
.
messengerAddress
&&
log
.
address
===
layer
.
messengerAddress
&&
log
.
topics
[
0
]
===
SENT_MESSAGE
log
.
topics
[
0
]
===
ethers
.
utils
.
id
(
'
SentMessage(address,address,bytes,uint256,uint256)
'
)
)
{
)
{
const
[
message
]
=
ethers
.
utils
.
defaultAbiCoder
.
decode
(
const
[
,
,
message
,
,
]
=
ethers
.
utils
.
defaultAbiCoder
.
decode
(
[
'
bytes
'
],
[
'
address
'
,
'
address
'
,
'
bytes
'
,
'
uint256
'
,
'
uint256
'
],
log
.
data
log
.
data
)
)
msgHashes
.
push
(
ethers
.
utils
.
solidityKeccak256
([
'
bytes
'
],
[
message
]))
msgHashes
.
push
(
ethers
.
utils
.
solidityKeccak256
([
'
bytes
'
],
[
message
]))
...
...
packages/message-relayer/src/relay-tx.ts
View file @
92d675b5
...
@@ -92,17 +92,11 @@ export const getMessagesByTransactionHash = async (
...
@@ -92,17 +92,11 @@ export const getMessagesByTransactionHash = async (
// Decode the messages and turn them into a nicer struct.
// Decode the messages and turn them into a nicer struct.
const
sentMessages
=
sentMessageEvents
.
map
((
sentMessageEvent
)
=>
{
const
sentMessages
=
sentMessageEvents
.
map
((
sentMessageEvent
)
=>
{
const
encodedMessage
=
sentMessageEvent
.
args
.
message
const
decodedMessage
=
l2CrossDomainMessenger
.
interface
.
decodeFunctionData
(
'
relayMessage
'
,
encodedMessage
)
return
{
return
{
target
:
decodedMessage
.
_
target
,
target
:
sentMessageEvent
.
args
.
target
,
sender
:
decodedMessage
.
_
sender
,
sender
:
sentMessageEvent
.
args
.
sender
,
message
:
decodedMessage
.
_message
,
message
:
sentMessageEvent
.
args
.
message
,
// decoded message
messageNonce
:
decodedMessage
.
_
messageNonce
.
toNumber
(),
messageNonce
:
sentMessageEvent
.
args
.
messageNonce
.
toNumber
(),
}
}
})
})
...
...
packages/message-relayer/src/service.ts
View file @
92d675b5
...
@@ -387,20 +387,24 @@ export class MessageRelayerService extends BaseService<MessageRelayerOptions> {
...
@@ -387,20 +387,24 @@ export class MessageRelayerService extends BaseService<MessageRelayerOptions> {
)
)
const
messages
=
events
.
map
((
event
)
=>
{
const
messages
=
events
.
map
((
event
)
=>
{
const
message
=
event
.
args
.
message
const
encodedMessage
=
const
decoded
=
this
.
state
.
OVM_L2CrossDomainMessenger
.
interface
.
encodeFunctionData
(
this
.
state
.
OVM_L2CrossDomainMessenger
.
interface
.
decodeFunctionData
(
'
relayMessage
'
,
'
relayMessage
'
,
message
[
event
.
args
.
target
,
event
.
args
.
sender
,
event
.
args
.
message
,
event
.
args
.
messageNonce
,
]
)
)
return
{
return
{
target
:
decoded
.
_
target
,
target
:
event
.
args
.
target
,
sender
:
decoded
.
_
sender
,
sender
:
event
.
args
.
sender
,
message
:
decoded
.
_
message
,
message
:
event
.
args
.
message
,
messageNonce
:
decoded
.
_
messageNonce
,
messageNonce
:
event
.
args
.
messageNonce
,
encodedMessage
:
message
,
encodedMessage
,
encodedMessageHash
:
ethers
.
utils
.
keccak256
(
m
essage
),
encodedMessageHash
:
ethers
.
utils
.
keccak256
(
encodedM
essage
),
parentTransactionIndex
:
event
.
blockNumber
-
this
.
options
.
l2BlockOffset
,
parentTransactionIndex
:
event
.
blockNumber
-
this
.
options
.
l2BlockOffset
,
parentTransactionHash
:
event
.
transactionHash
,
parentTransactionHash
:
event
.
transactionHash
,
}
}
...
...
packages/message-relayer/test/test-contracts/MockL2CrossDomainMessenger.sol
View file @
92d675b5
...
@@ -10,7 +10,12 @@ contract MockL2CrossDomainMessenger {
...
@@ -10,7 +10,12 @@ contract MockL2CrossDomainMessenger {
uint256 messageNonce;
uint256 messageNonce;
}
}
event SentMessage(address indexed target, bytes message, uint256 messageNonce, uint256 gasLimit);
event SentMessage(
address indexed target,
address sender,
bytes message,
uint256 messageNonce,
uint256 gasLimit);
function emitSentMessageEvent(
function emitSentMessageEvent(
MessageData memory _message
MessageData memory _message
...
@@ -19,6 +24,7 @@ contract MockL2CrossDomainMessenger {
...
@@ -19,6 +24,7 @@ contract MockL2CrossDomainMessenger {
{
{
emit SentMessage(
emit SentMessage(
_message.target,
_message.target,
_message.sender,
_message.message,
_message.message,
_message.messageNonce,
_message.messageNonce,
0
0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment