batch-submitter: updated config (#847)

* batch-submitter: backwards compatible configuration

* chore: add changeset

* deps: update

* js: move bcfg interface to core-utils

* batch-submitter: parse USE_SENTRY and add to env example

* chore: add changeset

* batch-submitter: parse as float instead of int

* batch-submitter: better error logging

.changeset/lovely-plants-clean.md

+---
+'@eth-optimism/core-utils': patch
+'@eth-optimism/data-transport-layer': patch
+'@eth-optimism/message-relayer': patch
+---
+
+Migrate bcfg interface to core-utils

.changeset/soft-squids-switch.md

+---
+'@eth-optimism/batch-submitter': patch
+---
+
+Updates the configuration to use bcfg in a backwards compatible way

packages/batch-submitter/.env.example

@@ -7,6 +7,7 @@ DEBUG=info*,error*,warn*,debug*
 # Leave the SENTRY_DSN variable unset during local development
 SENTRY_DSN=
 SENTRY_TRACE_RATE=
+USE_SENTRY=
 
 L1_NODE_WEB3_URL=http://localhost:9545
 L2_NODE_WEB3_URL=http://localhost:8545

packages/batch-submitter/package.json

@@ -37,6 +37,7 @@
     "@eth-optimism/ynatm": "^0.2.2",
     "@ethersproject/abstract-provider": "^5.0.5",
     "@ethersproject/providers": "^5.0.14",
+    "bcfg": "^0.1.6",
     "bluebird": "^3.7.2",
     "dotenv": "^8.2.0",
     "ethers": "5.0.0",

packages/core-utils/src/bcfg.ts

+export interface Bcfg {
+  load: (options: { env?: boolean; argv?: boolean }) => void
+  str: (name: string, defaultValue?: string) => string
+  uint: (name: string, defaultValue?: number) => number
+  bool: (name: string, defaultValue?: boolean) => boolean
+  ufloat: (name: string, defaultValue?: number) => number
+  has: (name: string) => boolean
+}

packages/core-utils/src/index.ts

@@ -4,3 +4,4 @@ export * from './watcher'
 export * from './l2context'
 export * from './events'
 export * from './batches'
+export * from './bcfg'

packages/data-transport-layer/src/services/run.ts

 /* Imports: External */
 import * as dotenv from 'dotenv'
-import Config from 'bcfg' // TODO: Add some types for bcfg if we get the chance.
+import { Bcfg } from '@eth-optimism/core-utils'
+import Config from 'bcfg'
 
 /* Imports: Internal */
 import { L1DataTransportService } from './main/service'
 
-interface Bcfg {
-  load: (options: { env?: boolean; argv?: boolean }) => void
-  str: (name: string, defaultValue?: string) => string
-  uint: (name: string, defaultValue?: number) => number
-  bool: (name: string, defaultValue?: boolean) => boolean
-  ufloat: (name: string, defaultValue?: number) => number
-}
-
 type ethNetwork = 'mainnet' | 'kovan' | 'goerli'
 ;(async () => {
   try {

packages/message-relayer/src/exec/run.ts

 import { Wallet, providers } from 'ethers'
 import { MessageRelayerService } from '../service'
+import { Bcfg } from '@eth-optimism/core-utils'
 import SpreadSheet from '../spreadsheet'
 import * as dotenv from 'dotenv'
 import Config from 'bcfg'
 
-interface Bcfg {
-  load: (options: { env?: boolean; argv?: boolean }) => void
-  str: (name: string, defaultValue?: string) => string
-  uint: (name: string, defaultValue?: number) => number
-  bool: (name: string, defaultValue?: boolean) => boolean
-  ufloat: (name: string, defaultValue?: number) => number
-}
-
 dotenv.config()
 
 const main = async () => {