Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
9c02f544
Unverified
Commit
9c02f544
authored
Sep 24, 2024
by
Matt Solomon
Committed by
GitHub
Sep 24, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore: emit event on deploy (#12090)
parent
712b760f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
4 deletions
+10
-4
semver-lock.json
packages/contracts-bedrock/semver-lock.json
+2
-2
OPStackManager.sol
packages/contracts-bedrock/src/L1/OPStackManager.sol
+3
-2
OPStackManager.t.sol
packages/contracts-bedrock/test/L1/OPStackManager.t.sol
+5
-0
No files found.
packages/contracts-bedrock/semver-lock.json
View file @
9c02f544
...
...
@@ -32,8 +32,8 @@
"sourceCodeHash"
:
"0xde4df0f9633dc0cdb1c9f634003ea5b0f7c5c1aebc407bc1b2f44c0ecf938649"
},
"src/L1/OPStackManager.sol"
:
{
"initCodeHash"
:
"0x
5b451782192b8429f6822c88270c4f0dbd10342518c5695ecf4dff7b5ebfb4e4
"
,
"sourceCodeHash"
:
"0x
4a9c242ce96471437ec97662d2365a7bda376db765c630a41cbe238811f1df51
"
"initCodeHash"
:
"0x
92c72b75206e756742df25d67d295e4479e65db1473948b8f53cb4ca642025d5
"
,
"sourceCodeHash"
:
"0x
3cbd30c68cad0dd18d49165bd21d94422b7403174f91a733e2398539dadf8656
"
},
"src/L1/OptimismPortal.sol"
:
{
"initCodeHash"
:
"0xbe2c0c81b3459014f287d8c89cdc0d27dde5d1f44e5d024fa1e4773ddc47c190"
,
...
...
packages/contracts-bedrock/src/L1/OPStackManager.sol
View file @
9c02f544
...
...
@@ -124,8 +124,8 @@ contract OPStackManager is ISemver, Initializable {
// -------- Constants and Variables --------
/// @custom:semver 1.0.0-beta.
5
string public constant version = "1.0.0-beta.
5
";
/// @custom:semver 1.0.0-beta.
6
string public constant version = "1.0.0-beta.
6
";
/// @notice Address of the SuperchainConfig contract shared by all chains.
SuperchainConfig public immutable superchainConfig;
...
...
@@ -334,6 +334,7 @@ contract OPStackManager is ISemver, Initializable {
// Transfer ownership of the ProxyAdmin from this contract to the specified owner.
output.opChainProxyAdmin.transferOwnership(_input.roles.opChainProxyAdminOwner);
emit Deployed(l2ChainId, output.systemConfigProxy);
return output;
}
...
...
packages/contracts-bedrock/test/L1/OPStackManager.t.sol
View file @
9c02f544
...
...
@@ -9,6 +9,7 @@ import { DeployOPChain_TestBase } from "test/DeployOPChain.t.sol";
import { OPStackManager } from "src/L1/OPStackManager.sol";
import { SuperchainConfig } from "src/L1/SuperchainConfig.sol";
import { ProtocolVersions } from "src/L1/ProtocolVersions.sol";
import { SystemConfig } from "src/L1/SystemConfig.sol";
// Exposes internal functions for testing.
contract OPStackManager_Harness is OPStackManager {
...
...
@@ -33,6 +34,8 @@ contract OPStackManager_Harness is OPStackManager {
contract OPStackManager_Deploy_Test is DeployOPChain_TestBase {
using stdStorage for StdStorage;
event Deployed(uint256 indexed l2ChainId, SystemConfig indexed systemConfig);
function setUp() public override {
DeployOPChain_TestBase.setUp();
...
...
@@ -83,6 +86,8 @@ contract OPStackManager_Deploy_Test is DeployOPChain_TestBase {
}
function test_deploy_succeeds() public {
vm.expectEmit(true, false, true, true); // TODO precompute the system config address.
emit Deployed(doi.l2ChainId(), SystemConfig(address(1)));
opsm.deploy(toOPSMDeployInput(doi));
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment