Merge pull request #1904 from cfromknecht/bss-batch-creation-gauge

feat: add batchTxBuildTime performance gauge

.changeset/spicy-mayflies-complain.md

+---
+'@eth-optimism/batch-submitter': patch
+---
+
+adds batchTxBuildTime gauge

packages/batch-submitter/src/batch-submitter/batch-submitter.ts

@@ -31,6 +31,7 @@ interface BatchSubmitterMetrics {
   batchesSubmitted: Counter<string>
   failedSubmissions: Counter<string>
   malformedBatches: Counter<string>
+  batchTxBuildTime: Gauge<string>
 }
 
 export abstract class BatchSubmitter {
@@ -293,6 +294,11 @@ export abstract class BatchSubmitter {
         help: 'Count of malformed batches',
         registers: [metrics.registry],
       }),
+      batchTxBuildTime: new metrics.client.Gauge({
+        name: 'batch_tx_build_time',
+        help: 'Time to construct batch transaction',
+        registers: [metrics.registry],
+      }),
     }
   }
 }

packages/batch-submitter/src/batch-submitter/state-batch-submitter.ts

@@ -154,6 +154,9 @@ export class StateBatchSubmitter extends BatchSubmitter {
     startBlock: number,
     endBlock: number
   ): Promise<TransactionReceipt> {
+
+    const batchTxBuildStart = performance.now()
+
     const batch = await this._generateStateCommitmentBatch(startBlock, endBlock)
     const calldata = this.chainContract.interface.encodeFunctionData(
       'appendStateBatch',
@@ -169,6 +172,9 @@ export class StateBatchSubmitter extends BatchSubmitter {
       return
     }
 
+    const batchTxBuildEnd = performance.now()
+    this.metrics.batchTxBuildTime.set(batchTxBuildEnd - batchTxBuildStart)
+
     const offsetStartsAtIndex = startBlock - this.blockOffset
     this.logger.debug('Submitting batch.', { calldata })
 

packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts

@@ -203,6 +203,8 @@ export class TransactionBatchSubmitter extends BatchSubmitter {
       return
     }
 
+    const batchTxBuildStart = performance.now()
+
     const params = await this._generateSequencerBatchParams(
       startBlock,
       endBlock
@@ -226,6 +228,10 @@ export class TransactionBatchSubmitter extends BatchSubmitter {
     if (!wasBatchTruncated && !this._shouldSubmitBatch(batchSizeInBytes)) {
       return
     }
+
+    const batchTxBuildEnd = performance.now()
+    this.metrics.batchTxBuildTime.set(batchTxBuildEnd - batchTxBuildStart)
+
     this.metrics.numTxPerBatch.observe(endBlock - startBlock)
     const l1tipHeight = await this.signer.provider.getBlockNumber()
     this.logger.debug('Submitting batch.', {