Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
a666c4f2
Commit
a666c4f2
authored
Jul 11, 2023
by
Will Cory
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(sdk): Add missing message statuses
parent
d80c145e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
45 additions
and
15 deletions
+45
-15
bright-mayflies-jog.md
.changeset/bright-mayflies-jog.md
+5
-0
cross-chain-messenger.ts
packages/sdk/src/cross-chain-messenger.ts
+40
-15
No files found.
.changeset/bright-mayflies-jog.md
0 → 100644
View file @
a666c4f2
---
'
@eth-optimism/sdk'
:
patch
---
Fixed missing indexes for multicall support
packages/sdk/src/cross-chain-messenger.ts
View file @
a666c4f2
...
@@ -1563,9 +1563,17 @@ export class CrossChainMessenger {
...
@@ -1563,9 +1563,17 @@ export class CrossChainMessenger {
opts
?:
{
opts
?:
{
signer
?:
Signer
signer
?:
Signer
overrides
?:
Overrides
overrides
?:
Overrides
}
},
/**
* The index of the withdrawal if multiple are made with multicall
*/
messageIndex
:
number
=
0
):
Promise
<
TransactionResponse
>
{
):
Promise
<
TransactionResponse
>
{
const
tx
=
await
this
.
populateTransaction
.
proveMessage
(
message
,
opts
)
const
tx
=
await
this
.
populateTransaction
.
proveMessage
(
message
,
opts
,
messageIndex
)
return
(
opts
?.
signer
||
this
.
l1Signer
).
sendTransaction
(
tx
)
return
(
opts
?.
signer
||
this
.
l1Signer
).
sendTransaction
(
tx
)
}
}
...
@@ -1584,10 +1592,18 @@ export class CrossChainMessenger {
...
@@ -1584,10 +1592,18 @@ export class CrossChainMessenger {
opts
?:
{
opts
?:
{
signer
?:
Signer
signer
?:
Signer
overrides
?:
PayableOverrides
overrides
?:
PayableOverrides
}
},
/**
* The index of the withdrawal if multiple are made with multicall
*/
messageIndex
=
0
):
Promise
<
TransactionResponse
>
{
):
Promise
<
TransactionResponse
>
{
return
(
opts
?.
signer
||
this
.
l1Signer
).
sendTransaction
(
return
(
opts
?.
signer
||
this
.
l1Signer
).
sendTransaction
(
await
this
.
populateTransaction
.
finalizeMessage
(
message
,
opts
)
await
this
.
populateTransaction
.
finalizeMessage
(
message
,
opts
,
messageIndex
)
)
)
}
}
...
@@ -1810,7 +1826,6 @@ export class CrossChainMessenger {
...
@@ -1810,7 +1826,6 @@ export class CrossChainMessenger {
opts
?:
{
opts
?:
{
overrides
?:
Overrides
overrides
?:
Overrides
},
},
/**
/**
* The index of the withdrawal if multiple are made with multicall
* The index of the withdrawal if multiple are made with multicall
*/
*/
...
@@ -1822,13 +1837,17 @@ export class CrossChainMessenger {
...
@@ -1822,13 +1837,17 @@ export class CrossChainMessenger {
}
}
if
(
this
.
bedrock
)
{
if
(
this
.
bedrock
)
{
return
this
.
populateTransaction
.
finalizeMessage
(
resolved
,
{
return
this
.
populateTransaction
.
finalizeMessage
(
...(
opts
||
{}),
resolved
,
overrides
:
{
{
...
opts
?.
overrides
,
...(
opts
||
{}),
gasLimit
:
messageGasLimit
,
overrides
:
{
...
opts
?.
overrides
,
gasLimit
:
messageGasLimit
,
},
},
},
})
messageIndex
)
}
else
{
}
else
{
const
legacyL1XDM
=
new
ethers
.
Contract
(
const
legacyL1XDM
=
new
ethers
.
Contract
(
this
.
contracts
.
l1
.
L1CrossDomainMessenger
.
address
,
this
.
contracts
.
l1
.
L1CrossDomainMessenger
.
address
,
...
@@ -1861,7 +1880,6 @@ export class CrossChainMessenger {
...
@@ -1861,7 +1880,6 @@ export class CrossChainMessenger {
opts
?:
{
opts
?:
{
overrides
?:
PayableOverrides
overrides
?:
PayableOverrides
},
},
/**
/**
* The index of the withdrawal if multiple are made with multicall
* The index of the withdrawal if multiple are made with multicall
*/
*/
...
@@ -1921,7 +1939,6 @@ export class CrossChainMessenger {
...
@@ -1921,7 +1939,6 @@ export class CrossChainMessenger {
opts
?:
{
opts
?:
{
overrides
?:
PayableOverrides
overrides
?:
PayableOverrides
},
},
/**
/**
* The index of the withdrawal if multiple are made with multicall
* The index of the withdrawal if multiple are made with multicall
*/
*/
...
@@ -2229,10 +2246,18 @@ export class CrossChainMessenger {
...
@@ -2229,10 +2246,18 @@ export class CrossChainMessenger {
message
:
MessageLike
,
message
:
MessageLike
,
opts
?:
{
opts
?:
{
overrides
?:
CallOverrides
overrides
?:
CallOverrides
}
},
/**
* The index of the withdrawal if multiple are made with multicall
*/
messageIndex
=
0
):
Promise
<
BigNumber
>
=>
{
):
Promise
<
BigNumber
>
=>
{
return
this
.
l1Provider
.
estimateGas
(
return
this
.
l1Provider
.
estimateGas
(
await
this
.
populateTransaction
.
finalizeMessage
(
message
,
opts
)
await
this
.
populateTransaction
.
finalizeMessage
(
message
,
opts
,
messageIndex
)
)
)
},
},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment