Move incrementing the messageNonce to the end of function execution

ae5a69f1 · elenadimitrova · Kelvin Fichter · 9442d059 · ae5a69f1
Commit ae5a69f1 authored Sep 09, 2021 by elenadimitrova Committed by Kelvin Fichter Nov 10, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

OVM_L2CrossDomainMessenger.sol ...cts/contracts/L2/messaging/OVM_L2CrossDomainMessenger.sol +2 -1

No files found.
--- a/packages/contracts/contracts/L2/messaging/OVM_L2CrossDomainMessenger.sol
+++ b/packages/contracts/contracts/L2/messaging/OVM_L2CrossDomainMessenger.sol
@@ -98,11 +98,12 @@ contract OVM_L2CrossDomainMessenger is
            messageNonce
        );

-        messageNonce += 1;
        sentMessages[keccak256(xDomainCalldata)] = true;

        _sendXDomainMessage(xDomainCalldata, _gasLimit);
        emit SentMessage(_target, msg.sender, _message, messageNonce, _gasLimit);
+
+        messageNonce += 1;
    }

    /**