Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
b0db7db6
Unverified
Commit
b0db7db6
authored
Apr 04, 2023
by
Joshua Gutow
Committed by
GitHub
Apr 04, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #5342 from ethereum-optimism/jm/fix-slither
fix(ctb): Do not run slither triage in CI
parents
d34b3026
45a8e36c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
4 deletions
+6
-4
slither.sh
packages/contracts-bedrock/scripts/slither.sh
+5
-3
slither.config.json
packages/contracts-bedrock/slither.config.json
+1
-1
No files found.
packages/contracts-bedrock/scripts/slither.sh
View file @
b0db7db6
...
...
@@ -3,7 +3,11 @@
rm
-rf
artifacts forge-artifacts
# See slither.config.json for slither settings
if
[
-n
"
$TRIAGE_MODE
"
]
;
then
if
[[
-z
"
$TRIAGE_MODE
"
]]
;
then
echo
"Running slither"
slither
.
else
echo
"Running slither in triage mode"
# Slither's triage mode will run an 'interview' in the terminal, allowing you to review each of
# its findings, and specify which should be ignored in future runs of slither. This will update
# (or create) the slither.db.json file. This DB is a cleaner alternative to adding slither-disable
...
...
@@ -20,6 +24,4 @@ if [ -n "$TRIAGE_MODE" ]; then
mv
$DB
$TEMP_DB
jq
'walk(if type == "object" then del(.filename_absolute) else . end)'
$TEMP_DB
>
$DB
rm
-f
$TEMP_DB
else
slither
.
fi
packages/contracts-bedrock/slither.config.json
View file @
b0db7db6
{
"detectors_to_exclude"
:
"assembly-usage,block-timestamp,naming-convention,solc-version"
,
"detectors_to_exclude"
:
"assembly-usage,block-timestamp,naming-convention,solc-version
,low-level-calls
"
,
"exclude_informational"
:
true
,
"exclude_low"
:
true
,
"exclude_medium"
:
true
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment