Skip to content

N
nebula
Commit b15fe51a authored by Felipe Andrade's avatar Felipe Andrade
Browse files
Options

semgrep

parent c7c21a29
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
proxyd/consensus_tracker.go
View file @ b15fe51a
...@@ -237,6 +237,8 @@ func (ct *RedisConsensusTracker) stateHeartbeat() { ...@@ -237,6 +237,8 @@ func (ct *RedisConsensusTracker) stateHeartbeat() {
redsync.WithFailFast(true), redsync.WithFailFast(true),
redsync.WithTries(1)) redsync.WithTries(1))
// nosemgrep: missing-unlock-before-return
// this lock is hold indefinitely, and it is extended until the leader dies
if err := mutex.Lock(); err != nil { if err := mutex.Lock(); err != nil {
log.Debug("failed to obtain lock", "err", err) log.Debug("failed to obtain lock", "err", err)
ct.leader = false ct.leader = false
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment