Commit b1779589 authored by Mark Tyneway's avatar Mark Tyneway

contracts-bedrock: simplify interface

parent c684cb11
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
| msgNonce | uint240 | 205 | 0 | 30 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger | | msgNonce | uint240 | 205 | 0 | 30 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger |
| failedMessages | mapping(bytes32 => bool) | 206 | 0 | 32 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger | | failedMessages | mapping(bytes32 => bool) | 206 | 0 | 32 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger |
| __gap | uint256[42] | 207 | 0 | 1344 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger | | __gap | uint256[42] | 207 | 0 | 1344 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger |
| _PORTAL | contract OptimismPortal | 249 | 0 | 20 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger | | PORTAL | contract OptimismPortal | 249 | 0 | 20 | src/L1/L1CrossDomainMessenger.sol:L1CrossDomainMessenger |
======================= =======================
➡ src/L1/L1StandardBridge.sol:L1StandardBridge ➡ src/L1/L1StandardBridge.sol:L1StandardBridge
......
...@@ -14,7 +14,8 @@ import { Semver } from "../universal/Semver.sol"; ...@@ -14,7 +14,8 @@ import { Semver } from "../universal/Semver.sol";
contract L1CrossDomainMessenger is CrossDomainMessenger, Semver { contract L1CrossDomainMessenger is CrossDomainMessenger, Semver {
/// @notice Address of the OptimismPortal. /// @notice Address of the OptimismPortal.
/// @custom:network-specific /// @custom:network-specific
OptimismPortal internal _PORTAL; /// @custom:legacy
OptimismPortal public PORTAL;
/// @custom:semver 1.5.0 /// @custom:semver 1.5.0
/// @notice Constructs the L1CrossDomainMessenger contract. /// @notice Constructs the L1CrossDomainMessenger contract.
...@@ -25,19 +26,13 @@ contract L1CrossDomainMessenger is CrossDomainMessenger, Semver { ...@@ -25,19 +26,13 @@ contract L1CrossDomainMessenger is CrossDomainMessenger, Semver {
/// @notice Initializes the contract. /// @notice Initializes the contract.
/// @param _portal Address of the OptimismPortal contract on this network. /// @param _portal Address of the OptimismPortal contract on this network.
function initialize(OptimismPortal _portal) public reinitializer(2) { function initialize(OptimismPortal _portal) public reinitializer(2) {
_PORTAL = _portal; PORTAL = _portal;
__CrossDomainMessenger_init(); __CrossDomainMessenger_init();
} }
/// @notice Getter for the OptimismPortal address.
/// @custom:legacy
function PORTAL() external view returns (address) {
return address(_PORTAL);
}
/// @notice Getter for the OptimismPortal address. /// @notice Getter for the OptimismPortal address.
function portal() external view returns (address) { function portal() external view returns (address) {
return address(_PORTAL); return address(PORTAL);
} }
/// @inheritdoc CrossDomainMessenger /// @inheritdoc CrossDomainMessenger
...@@ -47,16 +42,16 @@ contract L1CrossDomainMessenger is CrossDomainMessenger, Semver { ...@@ -47,16 +42,16 @@ contract L1CrossDomainMessenger is CrossDomainMessenger, Semver {
uint256 _value, uint256 _value,
bytes memory _data bytes memory _data
) internal override { ) internal override {
_PORTAL.depositTransaction{ value: _value }(_to, _value, _gasLimit, false, _data); PORTAL.depositTransaction{ value: _value }(_to, _value, _gasLimit, false, _data);
} }
/// @inheritdoc CrossDomainMessenger /// @inheritdoc CrossDomainMessenger
function _isOtherMessenger() internal view override returns (bool) { function _isOtherMessenger() internal view override returns (bool) {
return msg.sender == address(_PORTAL) && _PORTAL.l2Sender() == OTHER_MESSENGER; return msg.sender == address(PORTAL) && PORTAL.l2Sender() == OTHER_MESSENGER;
} }
/// @inheritdoc CrossDomainMessenger /// @inheritdoc CrossDomainMessenger
function _isUnsafeTarget(address _target) internal view override returns (bool) { function _isUnsafeTarget(address _target) internal view override returns (bool) {
return _target == address(this) || _target == address(_PORTAL); return _target == address(this) || _target == address(PORTAL);
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment