Merge branch 'develop' into jg/typo

.changeset/fluffy-geese-yell.md

+---
+'@eth-optimism/atst': minor
+---
+
+Remove broken allowFailures as option

packages/atst/docs/sdk.md

@@ -171,11 +171,6 @@ const attestation = await readAttestations({
    * @defaults defaults to the create2 address
    */
   contractAddress,
-  /**
-   * Boolean: Whether to allow some of the calls to fail
-   * Defaults to false
-   */
-  allowFailures,
 })
 ```
 

packages/atst/src/cli.ts

@@ -15,13 +15,13 @@ cli
   .option('--creator <string>', readOptionsValidators.creator.description!)
   .option('--about <string>', readOptionsValidators.about.description!)
   .option('--key <string>', readOptionsValidators.key.description!)
-  .option('--data-type [string]', readOptionsValidators.dataType.description!, {
+  .option('--data-type <string>', readOptionsValidators.dataType.description!, {
     default: readOptionsValidators.dataType.parse(undefined),
   })
-  .option('--rpc-url [url]', readOptionsValidators.rpcUrl.description!, {
+  .option('--rpc-url <url>', readOptionsValidators.rpcUrl.description!, {
     default: readOptionsValidators.rpcUrl.parse(undefined),
   })
-  .option('--contract [address]', readOptionsValidators.contract.description!, {
+  .option('--contract <address>', readOptionsValidators.contract.description!, {
     default: readOptionsValidators.contract.parse(undefined),
   })
   .example(
@@ -52,17 +52,17 @@ cli
     '--private-key <string>',
     writeOptionsValidators.privateKey.description!
   )
-  .option('--data-type [string]', readOptionsValidators.dataType.description!, {
+  .option('--data-type <string>', readOptionsValidators.dataType.description!, {
     default: writeOptionsValidators.dataType.parse(undefined),
   })
   .option('--about <string>', writeOptionsValidators.about.description!)
   .option('--key <string>', writeOptionsValidators.key.description!)
   .option('--value <string>', writeOptionsValidators.value.description!)
-  .option('--rpc-url [url]', writeOptionsValidators.rpcUrl.description!, {
+  .option('--rpc-url <url>', writeOptionsValidators.rpcUrl.description!, {
     default: writeOptionsValidators.rpcUrl.parse(undefined),
   })
   .option(
-    '--contract [address]',
+    '--contract <address>',
     writeOptionsValidators.contract.description!,
     {
       default: writeOptionsValidators.contract.parse(undefined),

packages/atst/src/lib/readAttestations.ts

@@ -19,7 +19,6 @@ import { parseAttestationBytes } from './parseAttestationBytes'
  *    creator: creatorAddress,
  *    about: aboutAddress,
  *    key: 'my_key',
- *    allowFailure: false,
  *  },
  *  {
  *    creator: creatorAddress2,
@@ -27,7 +26,6 @@ import { parseAttestationBytes } from './parseAttestationBytes'
  *    key: 'my_key',
  *    dataType: 'number',
  *    contractAddress: '0x1234',
- *    allowFailure: false,
  *   },
  * )
  */
@@ -40,7 +38,6 @@ export const readAttestations = async (
       about,
       key,
       contractAddress = ATTESTATION_STATION_ADDRESS,
-      allowFailure = false,
     } = attestation
     if (key.length > 32) {
       throw new Error(
@@ -52,7 +49,6 @@ export const readAttestations = async (
       abi,
       functionName: 'attestations',
       args: [creator, about, formatBytes32String(key) as WagmiBytes],
-      allowFailure,
     } as const
   })
 

packages/atst/src/types/AttestationReadParams.ts

@@ -11,5 +11,4 @@ export interface AttestationReadParams {
   key: string
   dataType?: DataTypeOption
   contractAddress?: Address
-  allowFailure?: boolean
 }