Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
b337c55f
Commit
b337c55f
authored
Aug 12, 2023
by
Noah Citron
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
use deterministic deployment for ERC721 factory
parent
7abe4d12
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
24 additions
and
9 deletions
+24
-9
OptimismMintableERC721Factory.sol
...s-bedrock/src/universal/OptimismMintableERC721Factory.sol
+2
-1
OptimismMintableERC20Factory.t.sol
...contracts-bedrock/test/OptimismMintableERC20Factory.t.sol
+0
-1
OptimismMintableERC721Factory.t.sol
...ontracts-bedrock/test/OptimismMintableERC721Factory.t.sol
+22
-7
No files found.
packages/contracts-bedrock/src/universal/OptimismMintableERC721Factory.sol
View file @
b337c55f
...
...
@@ -47,7 +47,8 @@ contract OptimismMintableERC721Factory is Semver {
{
require(_remoteToken != address(0), "OptimismMintableERC721Factory: L1 token address cannot be address(0)");
address localToken = address(new OptimismMintableERC721(BRIDGE, REMOTE_CHAIN_ID, _remoteToken, _name, _symbol));
bytes32 salt = keccak256(abi.encode(_remoteToken, _name, _symbol));
address localToken = address(new OptimismMintableERC721{salt: salt}(BRIDGE, REMOTE_CHAIN_ID, _remoteToken, _name, _symbol));
isOptimismMintableERC721[localToken] = true;
emit OptimismMintableERC721Created(localToken, _remoteToken, msg.sender);
...
...
packages/contracts-bedrock/test/OptimismMintableERC20Factory.t.sol
View file @
b337c55f
...
...
@@ -3,7 +3,6 @@ pragma solidity 0.8.15;
import { OptimismMintableERC20 } from "../src/universal/OptimismMintableERC20.sol";
import { Bridge_Initializer } from "./CommonTest.t.sol";
import { LibRLP } from "./RLP.t.sol";
contract OptimismMintableTokenFactory_Test is Bridge_Initializer {
event StandardL2TokenCreated(address indexed remoteToken, address indexed localToken);
...
...
packages/contracts-bedrock/test/OptimismMintableERC721Factory.t.sol
View file @
b337c55f
...
...
@@ -3,7 +3,6 @@ pragma solidity 0.8.15;
import { ERC721 } from "@openzeppelin/contracts/token/ERC721/ERC721.sol";
import { ERC721Bridge_Initializer } from "./CommonTest.t.sol";
import { LibRLP } from "./RLP.t.sol";
import { OptimismMintableERC721 } from "../src/universal/OptimismMintableERC721.sol";
import { OptimismMintableERC721Factory } from "../src/universal/OptimismMintableERC721Factory.sol";
...
...
@@ -28,20 +27,20 @@ contract OptimismMintableERC721Factory_Test is ERC721Bridge_Initializer {
}
function test_createOptimismMintableERC721_succeeds() external {
// Predict the address based on the factory address and nonce.
address
predicted = LibRLP.computeAddress(address(factory), 1
);
address remote = address(1234);
address
local = calculateTokenAddress(address(1234), "L2Token", "L2T"
);
// Expect a token creation event.
vm.expectEmit(true, true, true, true);
emit OptimismMintableERC721Created(
predicted, address(1234)
, alice);
emit OptimismMintableERC721Created(
local, remote
, alice);
// Create the token.
vm.prank(alice);
OptimismMintableERC721 created =
OptimismMintableERC721(factory.createOptimismMintableERC721(
address(1234)
, "L2Token", "L2T"));
OptimismMintableERC721(factory.createOptimismMintableERC721(
remote
, "L2Token", "L2T"));
// Token address should be correct.
assertEq(address(created),
predicted
);
assertEq(address(created),
local
);
// Should be marked as created by the factory.
assertEq(factory.isOptimismMintableERC721(address(created)), true);
...
...
@@ -49,7 +48,7 @@ contract OptimismMintableERC721Factory_Test is ERC721Bridge_Initializer {
// Token should've been constructed correctly.
assertEq(created.name(), "L2Token");
assertEq(created.symbol(), "L2T");
assertEq(created.REMOTE_TOKEN(),
address(1234)
);
assertEq(created.REMOTE_TOKEN(),
remote
);
assertEq(created.BRIDGE(), address(L2Bridge));
assertEq(created.REMOTE_CHAIN_ID(), 1);
}
...
...
@@ -59,4 +58,20 @@ contract OptimismMintableERC721Factory_Test is ERC721Bridge_Initializer {
vm.expectRevert("OptimismMintableERC721Factory: L1 token address cannot be address(0)");
factory.createOptimismMintableERC721(address(0), "L2Token", "L2T");
}
function calculateTokenAddress(
address _remote,
string memory _name,
string memory _symbol
)
internal
view
returns (address)
{
bytes memory constructorArgs = abi.encode(address(L2Bridge), 1, _remote, _name, _symbol);
bytes memory bytecode = abi.encodePacked(type(OptimismMintableERC721).creationCode, constructorArgs);
bytes32 salt = keccak256(abi.encode(_remote, _name, _symbol));
bytes32 hash = keccak256(abi.encodePacked(bytes1(0xff), address(factory), salt, keccak256(bytecode)));
return address(uint160(uint(hash)));
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment