ci: move `op-bindings` check to own job (#2981)

* ci: move `op-bindings` check to own job

This should speed up the CI so that the check for the
`op-bindings` runs in parallel with the `contracts-bedrock`
tests. This step is often very slow compared to others and
I often find myself waiting on it.

* contracts-bedrock: update readme

Delete some dead info
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

.circleci/config.yml

@@ -145,6 +145,24 @@ jobs:
           name: storage snapshot
           command: yarn storage-snapshot && git diff --exit-code .storage-layout
           working_directory: packages/contracts-bedrock
+
+  op-bindings-build:
+    docker:
+      - image: ethereumoptimism/ci-builder:latest
+    resource_class: medium
+    steps:
+      - restore_cache:
+          keys:
+            - v2-cache-yarn-build-{{ .Revision }}
+      - checkout
+      - run:
+          name: Check if we should run
+          command: |
+            shopt -s inherit_errexit
+            CHANGED=$(check-changed "(contracts-bedrock|op-bindings)")
+            if [[ "$CHANGED" = "FALSE" ]]; then
+              circleci step halt
+            fi
       - run:
           name: check go bindings
           command: make && git diff --exit-code
@@ -547,6 +565,9 @@ workflows:
       - contracts-bedrock-tests:
           requires:
             - yarn-monorepo
+      - op-bindings-build:
+          requires:
+            - yarn-monorepo
       - js-lint-test:
           name: contracts-governance-tests
           package_name: contracts-governance

packages/contracts-bedrock/README.md

@@ -2,8 +2,7 @@
 
 ## Install
 
-The repo currently uses a mix of typescript tests (run with HardHat) and solidity tests (run with Forge). The project
-uses the default hardhat directory structure, and all build/test steps should be run using the yarn scripts to ensure
+The repo currently uses solidity tests (run with Forge). The project uses the default hardhat directory structure, and all build/test steps should be run using the yarn scripts to ensure
 the correct options are set.
 
 Install node modules with yarn (v1), and Node.js (14+).
@@ -22,28 +21,12 @@ yarn build
 
 ## Running Tests
 
-First get the dependencies:
-
-`git submodule init` and `git submodule update`
-
 Then the full test suite can be executed via `yarn`:
 
 ```shell
 yarn test
 ```
 
-To run only typescript tests:
-
-```shell
-yarn test:hh
-```
-
-To run only solidity tests:
-
-```shell
-yarn test:forge
-```
-
 ## Deployment
 
 Create a file that corresponds to the network name in the `deploy-config`
@@ -52,7 +35,7 @@ directory and then run the command:
 ```shell
 L1_RPC=<ETHEREUM L1 RPC endpoint> \
 PRIVATE_KEY_DEPLOYER=<PRIVATE KEY TO PAY FOR THE DEPLOYMENT> \
-npx hardhat deploy --network <network-name>
+    npx hardhat deploy --network <network-name>
 ```
 
 In the `hardhat.config.ts`, there is a `deployConfigSpec` field that validates that the types