fix unicorn dependency on CI

.github/workflows/test_challenge.yml

@@ -16,6 +16,7 @@ jobs:
     - name: Install unicorn
       run: |
         ./build_unicorn.sh
+        echo "LIBUNICORN_PATH=$(pwd)/unicorn2/" >> $GITHUB_ENV
     - name: Install yarn
       run: |
         npm install --global yarn

.github/workflows/test_mipsevm.yml

@@ -16,6 +16,7 @@ jobs:
     - name: Install unicorn
       run: |
         ./build_unicorn.sh
+        echo "LIBUNICORN_PATH=$(pwd)/unicorn2/" >> $GITHUB_ENV
     - name: Install yarn
       run: |
         npm install --global yarn
@@ -29,9 +30,7 @@ jobs:
         minigeth/go-ethereum 13284469
         minigeth/go-ethereum 13284491
     - name: Install Python deps
-      run: |
-        pip3 install -r mipigo/requirements.txt
-        (cd unicorn2/bindings/python && python3 setup.py install)
+      run: pip3 install -r mipigo/requirements.txt
     - name: Build minigeth for embedded
       run: |
         cd mipigo

README.md

@@ -27,10 +27,7 @@ contracts -- A Merkleized MIPS processor on chain + the challenge logic
 The following commands should be run from the root directory unless otherwise specified:
 
 ```
-# build unicorn
 ./build_unicorn.sh
-(cd unicorn2/bindings/python && python3 setup.py install)
-export LIBUNICORN_PATH=$(pwd)/unicorn2/
 
 # build minigeth for MIPS
 (cd mipigo && ./build.sh)

build_unicorn.sh

 #!/bin/bash
-git clone https://github.com/geohot/unicorn.git -b dev unicorn2
-#git clone https://github.com/unicorn-engine/unicorn.git -b dev unicorn2
+if [[ ! -d unicorn2 ]]; then
+    git clone https://github.com/geohot/unicorn.git -b dev unicorn2
+    #git clone https://github.com/unicorn-engine/unicorn.git -b dev unicorn2
+fi
+
 cd unicorn2
-#cmake . -DUNICORN_ARCH=mips -DCMAKE_BUILD_TYPE=Debug
 cmake . -DUNICORN_ARCH=mips -DCMAKE_BUILD_TYPE=Release
+#cmake . -DUNICORN_ARCH=mips -DCMAKE_BUILD_TYPE=Debug
 make -j8
 
+# setting this avoids re-building unicorn in setup.py
+export LIBUNICORN_PATH=$(pwd)
+
+cd bindings/python
+sudo python3 setup.py install