style(ctb): Remove underscores from event args

packages/contracts-bedrock/contracts/L1/L1StandardBridge.sol

@@ -22,72 +22,72 @@ contract L1StandardBridge is StandardBridge, Initializable {
      * @custom:legacy
      * @notice Emitted whenever a deposit of ETH from L1 into L2 is initiated.
      *
-     * @param _from      Address of the depositor.
-     * @param _to        Address of the recipient on L2.
-     * @param _amount    Amount of ETH deposited.
-     * @param _extraData Extra data attached to the deposit.
+     * @param from      Address of the depositor.
+     * @param to        Address of the recipient on L2.
+     * @param amount    Amount of ETH deposited.
+     * @param extraData Extra data attached to the deposit.
      */
     event ETHDepositInitiated(
-        address indexed _from,
-        address indexed _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed from,
+        address indexed to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**
      * @custom:legacy
      * @notice Emitted whenever a withdrawal of ETH from L2 to L1 is finalized.
      *
-     * @param _from      Address of the withdrawer.
-     * @param _to        Address of the recipient on L1.
-     * @param _amount    Amount of ETH withdrawn.
-     * @param _extraData Extra data attached to the withdrawal.
+     * @param from      Address of the withdrawer.
+     * @param to        Address of the recipient on L1.
+     * @param amount    Amount of ETH withdrawn.
+     * @param extraData Extra data attached to the withdrawal.
      */
     event ETHWithdrawalFinalized(
-        address indexed _from,
-        address indexed _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed from,
+        address indexed to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**
      * @custom:legacy
      * @notice Emitted whenever an ERC20 deposit is initiated.
      *
-     * @param _l1Token   Address of the token on L1.
-     * @param _l2Token   Address of the corresponding token on L2.
-     * @param _from      Address of the depositor.
-     * @param _to        Address of the recipient on L2.
-     * @param _amount    Amount of the ERC20 deposited.
-     * @param _extraData Extra data attached to the deposit.
+     * @param l1Token   Address of the token on L1.
+     * @param l2Token   Address of the corresponding token on L2.
+     * @param from      Address of the depositor.
+     * @param to        Address of the recipient on L2.
+     * @param amount    Amount of the ERC20 deposited.
+     * @param extraData Extra data attached to the deposit.
      */
     event ERC20DepositInitiated(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**
      * @custom:legacy
      * @notice Emitted whenever an ERC20 withdrawal is finalized.
      *
-     * @param _l1Token   Address of the token on L1.
-     * @param _l2Token   Address of the corresponding token on L2.
-     * @param _from      Address of the withdrawer.
-     * @param _to        Address of the recipient on L1.
-     * @param _amount    Amount of the ERC20 withdrawn.
-     * @param _extraData Extra data attached to the withdrawal.
+     * @param l1Token   Address of the token on L1.
+     * @param l2Token   Address of the corresponding token on L2.
+     * @param from      Address of the withdrawer.
+     * @param to        Address of the recipient on L1.
+     * @param amount    Amount of the ERC20 withdrawn.
+     * @param extraData Extra data attached to the withdrawal.
      */
     event ERC20WithdrawalFinalized(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**

packages/contracts-bedrock/contracts/L1/L2OutputOracle.sol

@@ -30,31 +30,30 @@ contract L2OutputOracle is OwnableUpgradeable {
         uint256 timestamp;
     }
 
-    // TODO: Events should NOT be underscore prefixed.
     /**
      * @notice Emitted when an output is appended.
      *
-     * @param _l2Output      The output root.
-     * @param _l1Timestamp   The L1 timestamp when appended.
-     * @param _l2BlockNumber The L2 block number of the output root.
+     * @param l2Output      The output root.
+     * @param l1Timestamp   The L1 timestamp when appended.
+     * @param l2BlockNumber The L2 block number of the output root.
      */
     event L2OutputAppended(
-        bytes32 indexed _l2Output,
-        uint256 indexed _l1Timestamp,
-        uint256 indexed _l2BlockNumber
+        bytes32 indexed l2Output,
+        uint256 indexed l1Timestamp,
+        uint256 indexed l2BlockNumber
     );
 
     /**
      * @notice Emitted when an output is deleted.
      *
-     * @param _l2Output      The output root.
-     * @param _l1Timestamp   The L1 timestamp when appended.
-     * @param _l2BlockNumber The L2 block number of the output root.
+     * @param l2Output      The output root.
+     * @param l1Timestamp   The L1 timestamp when appended.
+     * @param l2BlockNumber The L2 block number of the output root.
      */
     event L2OutputDeleted(
-        bytes32 indexed _l2Output,
-        uint256 indexed _l1Timestamp,
-        uint256 indexed _l2BlockNumber
+        bytes32 indexed l2Output,
+        uint256 indexed l1Timestamp,
+        uint256 indexed l2BlockNumber
     );
 
     /**

packages/contracts-bedrock/contracts/L2/L2StandardBridge.sol

@@ -22,60 +22,60 @@ contract L2StandardBridge is StandardBridge {
      * @custom:legacy
      * @notice Emitted whenever a withdrawal from L2 to L1 is initiated.
      *
-     * @param _l1Token   Address of the token on L1.
-     * @param _l2Token   Address of the corresponding token on L2.
-     * @param _from      Address of the withdrawer.
-     * @param _to        Address of the recipient on L1.
-     * @param _amount    Amount of the ERC20 withdrawn.
-     * @param _extraData Extra data attached to the withdrawal.
+     * @param l1Token   Address of the token on L1.
+     * @param l2Token   Address of the corresponding token on L2.
+     * @param from      Address of the withdrawer.
+     * @param to        Address of the recipient on L1.
+     * @param amount    Amount of the ERC20 withdrawn.
+     * @param extraData Extra data attached to the withdrawal.
      */
     event WithdrawalInitiated(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**
      * @custom:legacy
      * @notice Emitted whenever an ERC20 deposit is finalized.
      *
-     * @param _l1Token   Address of the token on L1.
-     * @param _l2Token   Address of the corresponding token on L2.
-     * @param _from      Address of the depositor.
-     * @param _to        Address of the recipient on L2.
-     * @param _amount    Amount of the ERC20 deposited.
-     * @param _extraData Extra data attached to the deposit.
+     * @param l1Token   Address of the token on L1.
+     * @param l2Token   Address of the corresponding token on L2.
+     * @param from      Address of the depositor.
+     * @param to        Address of the recipient on L2.
+     * @param amount    Amount of the ERC20 deposited.
+     * @param extraData Extra data attached to the deposit.
      */
     event DepositFinalized(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**
      * @custom:legacy
      * @notice Emitted whenever a deposit fails.
      *
-     * @param _l1Token   Address of the token on L1.
-     * @param _l2Token   Address of the corresponding token on L2.
-     * @param _from      Address of the depositor.
-     * @param _to        Address of the recipient on L2.
-     * @param _amount    Amount of the ERC20 deposited.
-     * @param _extraData Extra data attached to the deposit.
+     * @param l1Token   Address of the token on L1.
+     * @param l2Token   Address of the corresponding token on L2.
+     * @param from      Address of the depositor.
+     * @param to        Address of the recipient on L2.
+     * @param amount    Amount of the ERC20 deposited.
+     * @param extraData Extra data attached to the deposit.
      */
     event DepositFailed(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _extraData
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes extraData
     );
 
     /**

packages/contracts-bedrock/contracts/legacy/AddressManager.sol

@@ -12,7 +12,7 @@ contract AddressManager is Ownable {
      * Events *
      **********/
 
-    event AddressSet(string indexed _name, address _newAddress, address _oldAddress);
+    event AddressSet(string indexed name, address newAddress, address oldAddress);
 
     /*************
      * Variables *

packages/contracts-bedrock/contracts/test/CommonTest.t.sol

@@ -231,103 +231,103 @@ contract Bridge_Initializer is Messenger_Initializer {
     OptimismMintableERC20 RemoteL1Token;
 
     event ETHDepositInitiated(
-        address indexed _from,
-        address indexed _to,
-        uint256 _amount,
-        bytes _data
+        address indexed from,
+        address indexed to,
+        uint256 amount,
+        bytes data
     );
 
     event ETHWithdrawalFinalized(
-        address indexed _from,
-        address indexed _to,
-        uint256 _amount,
-        bytes _data
+        address indexed from,
+        address indexed to,
+        uint256 amount,
+        bytes data
     );
 
     event ERC20DepositInitiated(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event ERC20WithdrawalFinalized(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event WithdrawalInitiated(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event DepositFinalized(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event DepositFailed(
-        address indexed _l1Token,
-        address indexed _l2Token,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed l1Token,
+        address indexed l2Token,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event ETHBridgeInitiated(
-        address indexed _from,
-        address indexed _to,
-        uint256 _amount,
-        bytes _data
+        address indexed from,
+        address indexed to,
+        uint256 amount,
+        bytes data
     );
 
     event ETHBridgeFinalized(
-        address indexed _from,
-        address indexed _to,
-        uint256 _amount,
-        bytes _data
+        address indexed from,
+        address indexed to,
+        uint256 amount,
+        bytes data
     );
 
     event ERC20BridgeInitiated(
-        address indexed _localToken,
-        address indexed _remoteToken,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed localToken,
+        address indexed remoteToken,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event ERC20BridgeFinalized(
-        address indexed _localToken,
-        address indexed _remoteToken,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed localToken,
+        address indexed remoteToken,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     event ERC20BridgeFailed(
-        address indexed _localToken,
-        address indexed _remoteToken,
-        address indexed _from,
-        address _to,
-        uint256 _amount,
-        bytes _data
+        address indexed localToken,
+        address indexed remoteToken,
+        address indexed from,
+        address to,
+        uint256 amount,
+        bytes data
     );
 
     function setUp() public virtual override {

packages/contracts-bedrock/contracts/test/L2OutputOracle.t.sol

@@ -250,9 +250,9 @@ contract L2OutputOracleTest is L2OutputOracle_Initializer {
      *****************************/
 
     event L2OutputDeleted(
-        bytes32 indexed _l2Output,
-        uint256 indexed _l1Timestamp,
-        uint256 indexed _l2BlockNumber
+        bytes32 indexed l2Output,
+        uint256 indexed l1Timestamp,
+        uint256 indexed l2BlockNumber
     );
 
     function test_deleteL2Output() external {

packages/contracts-bedrock/contracts/test/OptimismMintableERC20.t.sol

@@ -6,8 +6,8 @@ import "../universal/SupportedInterfaces.sol";
 import { IERC165 } from "@openzeppelin/contracts/utils/introspection/IERC165.sol";
 
 contract OptimismMintableERC20_Test is Bridge_Initializer {
-    event Mint(address indexed _account, uint256 _amount);
-    event Burn(address indexed _account, uint256 _amount);
+    event Mint(address indexed account, uint256 amount);
+    event Burn(address indexed account, uint256 amount);
 
     function setUp() public override {
         super.setUp();

packages/contracts-bedrock/contracts/test/OptimismMintableTokenFactory.t.sol

@@ -5,11 +5,11 @@ import { Bridge_Initializer } from "./CommonTest.t.sol";
 import { LibRLP } from "./RLP.t.sol";
 
 contract OptimismMintableTokenFactory_Test is Bridge_Initializer {
-    event StandardL2TokenCreated(address indexed _remoteToken, address indexed _localToken);
+    event StandardL2TokenCreated(address indexed remoteToken, address indexed localToken);
     event OptimismMintableTokenCreated(
-        address indexed _localToken,
-        address indexed _remoteToken,
-        address _deployer
+        address indexed localToken,
+        address indexed remoteToken,
+        address deployer
     );
 
     function setUp() public override {