Merge pull request #1799 from mslipper/bugfix/ctc-kovan-behind

batch-submitter: ENG-1688 fix bug causing Kovan to fall behind

.changeset/slow-dodos-argue.md

+---
+'@eth-optimism/batch-submitter': patch
+---
+
+Immediately reject on nonce errors to stop falling behind

packages/batch-submitter/src/utils/tx-submission.ts

@@ -28,6 +28,21 @@ const getGasPriceInGwei = async (signer: Signer): Promise<number> => {
   )
 }
 
+export const ynatmRejectOn = (e) => {
+  // taken almost verbatim from the readme,
+  // see https://github.com/ethereum-optimism/ynatm.
+  // immediately rejects on reverts and nonce errors
+  const errMsg = e.toString().toLowerCase()
+  const conditions = ['revert', 'nonce']
+  for (const cond of conditions) {
+    if (errMsg.includes(cond)) {
+      return true
+    }
+  }
+
+  return false
+}
+
 export const submitTransactionWithYNATM = async (
   tx: PopulatedTransaction,
   signer: Signer,
@@ -55,6 +70,7 @@ export const submitTransactionWithYNATM = async (
     maxGasPrice: ynatm.toGwei(config.maxGasPriceInGwei),
     gasPriceScalingFunction: ynatm.LINEAR(config.gasRetryIncrement),
     delay: config.resubmissionTimeout,
+    rejectImmediatelyOnCondition: ynatmRejectOn,
   })
   return receipt
 }

packages/batch-submitter/test/utils/tx-submission.spec.ts

@@ -124,4 +124,41 @@ describe('submitTransactionWithYNATM', async () => {
     }
     await submitTransactionWithYNATM(tx, signer, config, 0, nullHooks)
   })
+
+  it('should immediately reject if a nonce error is encountered', async () => {
+    const tx = {
+      gasPrice: BigNumber.from(1),
+      data: 'hello world!',
+    } as ethers.PopulatedTransaction
+
+    let txCount = 0
+    const waitForTransaction = async (): Promise<TransactionReceipt> => {
+      return {} as TransactionReceipt
+    }
+    const sendTransaction = async () => {
+      txCount++
+      throw new Error('Transaction nonce is too low.')
+    }
+    const signer = {
+      getGasPrice: async () => BigNumber.from(1),
+      sendTransaction: sendTransaction as any,
+      provider: {
+        waitForTransaction: waitForTransaction as any,
+      },
+    } as Signer
+
+    const config: ResubmissionConfig = {
+      resubmissionTimeout: 100,
+      minGasPriceInGwei: 0,
+      maxGasPriceInGwei: 1000,
+      gasRetryIncrement: 1,
+    }
+    try {
+      await submitTransactionWithYNATM(tx, signer, config, 0, nullHooks)
+    } catch (e) {
+      expect(txCount).to.equal(1)
+      return
+    }
+    expect.fail('Expected an error.')
+  })
 })