Commit c27aead5 authored by Matthew Slipper's avatar Matthew Slipper Committed by GitHub

Remove hardcoded entrypoint (#11801)

Removes the `ENTRYPOINT` directive in the `contracts-bedrock` image. While convenient, using `ENTRYPOINT` makes building tooling on top of the image much harder since the entrypoint cannot be overridden without providing special flags to Docker. It is easier to use a dummy `CMD` instead that directs users to call specific tools when running the container. Functionally, this means users will run `docker run just <cmd>` instead of `docker run <cmd>` if they want to use the Justfile.
parent 40750a58
...@@ -70,8 +70,4 @@ COPY --from=base /opt/optimism/versions.json /opt/optimism/versions.json ...@@ -70,8 +70,4 @@ COPY --from=base /opt/optimism/versions.json /opt/optimism/versions.json
WORKDIR /opt/optimism/packages/contracts-bedrock WORKDIR /opt/optimism/packages/contracts-bedrock
# Set "just" as entrypoint, so the default args (the Dockerfile CMD) CMD ["echo", "Override this command to use this image."]
# are passed in to it. This was previously "pnpm run" + "deploy".
ENTRYPOINT ["just"]
CMD ["deploy"]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment