Commit c313dc1a authored by Kelvin Fichter's avatar Kelvin Fichter

fix(sdk): test flakes #2

Additional tweaks to prevent test flakes in the SDK.
parent b63f5760
...@@ -249,7 +249,7 @@ task('deposit-erc20', 'Deposits WETH9 onto L2.') ...@@ -249,7 +249,7 @@ task('deposit-erc20', 'Deposits WETH9 onto L2.')
console.log(`ERC20 deposited - ${depositTx.hash}`) console.log(`ERC20 deposited - ${depositTx.hash}`)
// Deposit might get reorged, wait 10s and also log for reorgs. // Deposit might get reorged, wait 10s and also log for reorgs.
let prevBlockNumber = 0 let prevBlockHash: string = ''
for (let i = 0; i < 10; i++) { for (let i = 0; i < 10; i++) {
const messageReceipt = await messenger.waitForMessageReceipt(depositTx) const messageReceipt = await messenger.waitForMessageReceipt(depositTx)
if (messageReceipt.receiptStatus !== 1) { if (messageReceipt.receiptStatus !== 1) {
...@@ -258,25 +258,22 @@ task('deposit-erc20', 'Deposits WETH9 onto L2.') ...@@ -258,25 +258,22 @@ task('deposit-erc20', 'Deposits WETH9 onto L2.')
if ( if (
i > 0 && i > 0 &&
messageReceipt.transactionReceipt.blockNumber !== prevBlockNumber messageReceipt.transactionReceipt.blockHash !== prevBlockHash
) { ) {
console.log( console.log(
`Block number changed from ${prevBlockNumber} to ${messageReceipt.transactionReceipt.blockNumber}` `Block number changed from ${prevBlockHash} to ${messageReceipt.transactionReceipt.blockHash}`
) )
} }
prevBlockNumber = messageReceipt.transactionReceipt.blockNumber prevBlockHash = messageReceipt.transactionReceipt.blockHash
await sleep(1000) await sleep(1000)
}
const l2Balance = await OptimismMintableERC20.balanceOf(address) const l2Balance = await OptimismMintableERC20.balanceOf(address)
if (l2Balance.lt(utils.parseEther('1'))) { if (l2Balance.lt(utils.parseEther('1'))) {
throw new Error('bad deposit') throw new Error('bad deposit')
}
console.log(
`Deposit success - ${messageReceipt.transactionReceipt.transactionHash}`
)
} }
console.log(`Deposit success`)
console.log('Starting withdrawal') console.log('Starting withdrawal')
const preBalance = await WETH9.balanceOf(signer.address) const preBalance = await WETH9.balanceOf(signer.address)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment