contracts-bedrock: remove bindings requirement (#10285)

* contracts-bedrock: remove bindings requirement

Previously, CI enforced that bindings were kept up to date with
any changes to the smart contracts. This resulted in a lot of
churn with CI, created large diffs when opening PRs and also
took a long time to recompile and generate bindings.

Now that no major services depend on `op-bindings`, we can remove
the need to enforce they are kept up to date. The rest of the bindings
themselves can be removed in a separate PR. Merging this gives a sigh
of relief for all smart contract devs working on the optimism codebase.

* op-bindings-e2e: delete

.circleci/config.yml

@@ -613,41 +613,6 @@ jobs:
           command: pnpm validate-spacers
           working_directory: packages/contracts-bedrock
 
-  op-bindings-build:
-    docker:
-      - image: <<pipeline.parameters.ci_builder_image>>
-    resource_class: xlarge
-    steps:
-      - checkout
-      - run:
-          name: check go bindings
-          command: make && git diff --exit-code
-          working_directory: op-bindings
-
-  bindgen-remote:
-    docker:
-      - image: <<pipeline.parameters.ci_builder_image>>
-    resource_class: xlarge
-    steps:
-      - checkout
-      - run:
-          name: bindgen remote bindings
-          command: make bindgen-remote && git diff --exit-code
-          working_directory: op-bindings
-      - notify-failures-on-develop
-
-  bindgen-test-e2e:
-    docker:
-      - image: <<pipeline.parameters.ci_builder_image>>
-    resource_class: xlarge
-    steps:
-      - checkout
-      - run:
-          name: bindgen test E2E
-          command: make test-bindgen-e2e
-          working_directory: op-bindings-e2e
-      - notify-failures-on-develop
-
   js-lint-test:
     parameters:
       package_name:
@@ -1653,7 +1618,6 @@ workflows:
       - contracts-bedrock-validate-spaces:
           requires:
             - pnpm-monorepo
-      - op-bindings-build
       - js-lint-test:
           name: chain-mon-tests
           coverage_flag: chain-mon-tests
@@ -2371,19 +2335,6 @@ workflows:
             - oplabs-gcr
             - slack
 
-  scheduled-bindgen:
-    when:
-      equal: [ build_daily, <<pipeline.schedule.name>> ]
-    jobs:
-      - bindgen-remote:
-          context:
-            - slack
-            - oplabs-etherscan
-      - bindgen-test-e2e:
-          context:
-            - slack
-            - oplabs-etherscan
-
   scheduled-preimage-reproducibility:
     when:
       or:

op-bindings-e2e/Makefile

-test-bindgen-e2e:
-	go test ./... -count=1
\ No newline at end of file

op-bindings-e2e/remote_handlers_test.go

-package bindgen
-
-import (
-	"fmt"
-	"os"
-	"reflect"
-	"strings"
-	"testing"
-
-	"github.com/ethereum-optimism/optimism/op-bindings/bindgen"
-	"github.com/ethereum-optimism/optimism/op-bindings/etherscan"
-	"github.com/ethereum/go-ethereum/ethclient"
-)
-
-var generator bindgen.BindGenGeneratorRemote = bindgen.BindGenGeneratorRemote{}
-
-func configureGenerator(t *testing.T) error {
-	generator.ContractDataClients.Eth = etherscan.NewEthereumClient(os.Getenv("ETHERSCAN_APIKEY_ETH"))
-	generator.ContractDataClients.Op = etherscan.NewOptimismClient(os.Getenv("ETHERSCAN_APIKEY_OP"))
-
-	var err error
-	if generator.RpcClients.Eth, err = ethclient.Dial(os.Getenv("RPC_URL_ETH")); err != nil {
-		return fmt.Errorf("error initializing Ethereum client: %w", err)
-	}
-	if generator.RpcClients.Op, err = ethclient.Dial(os.Getenv("RPC_URL_OP")); err != nil {
-		return fmt.Errorf("error initializing Optimism client: %w", err)
-	}
-
-	return nil
-}
-
-func TestFetchContractData(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range fetchContractDataTests {
-		t.Run(tt.name, func(t *testing.T) {
-			contractData, err := generator.FetchContractData(tt.contractVerified, tt.chain, tt.deploymentAddress)
-			if err != nil {
-				t.Error(err)
-			}
-			if !reflect.DeepEqual(contractData, tt.expectedContractData) {
-				t.Errorf("Retrieved contract data doesn't match expected. Expected: %s Retrieved: %s", tt.expectedContractData, contractData)
-			}
-		})
-	}
-}
-
-func TestFetchContractDataFailures(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range fetchContractDataTestsFailures {
-		t.Run(tt.name, func(t *testing.T) {
-			_, err := generator.FetchContractData(tt.contractVerified, tt.chain, tt.deploymentAddress)
-			if err == nil {
-				t.Errorf("Expected error: %s but didn't receive it", tt.expectedError)
-				return
-			}
-
-			if !strings.Contains(err.Error(), tt.expectedError) {
-				t.Errorf("Expected error: %s Received: %s", tt.expectedError, err)
-				return
-			}
-		})
-	}
-}
-
-func TestCompareInitBytecodeWithOp(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range compareInitBytecodeWithOpTests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := generator.CompareInitBytecodeWithOp(&tt.contractMetadataEth, tt.initCodeShouldMatch)
-			if err != nil {
-				t.Error(err)
-			}
-		})
-	}
-}
-
-func TestCompareInitBytecodeWithOpFailures(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range compareInitBytecodeWithOpTestsFailures {
-		t.Run(tt.name, func(t *testing.T) {
-			err := generator.CompareInitBytecodeWithOp(&tt.contractMetadataEth, tt.initCodeShouldMatch)
-			if err == nil {
-				t.Errorf("Expected error: %s but didn't receive it", tt.expectedError)
-				return
-			}
-
-			if !strings.Contains(err.Error(), tt.expectedError) {
-				t.Errorf("Expected error: %s Received: %s", tt.expectedError, err)
-				return
-			}
-		})
-	}
-}
-
-func TestCompareDeployedBytecodeWithOp(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range compareDeployedBytecodeWithOpTests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := generator.CompareDeployedBytecodeWithOp(&tt.contractMetadataEth, tt.deployedCodeShouldMatch)
-			if err != nil {
-				t.Error(err)
-			}
-		})
-	}
-}
-
-func TestCompareDeployedBytecodeWithOpFailures(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range compareDeployedBytecodeWithOpTestsFailures {
-		t.Run(tt.name, func(t *testing.T) {
-			err := generator.CompareDeployedBytecodeWithOp(&tt.contractMetadataEth, tt.deployedCodeShouldMatch)
-			if err == nil {
-				t.Errorf("Expected error: %s but didn't receive it", tt.expectedError)
-				return
-			}
-
-			if !strings.Contains(err.Error(), tt.expectedError) {
-				t.Errorf("Expected error: %s Received: %s", tt.expectedError, err)
-				return
-			}
-		})
-	}
-}
-
-func TestCompareDeployedBytecodeWithRpc(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range compareDeployedBytecodeWithRpcTests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := generator.CompareDeployedBytecodeWithRpc(&tt.contractMetadataEth, tt.chain)
-			if err != nil {
-				t.Error(err)
-			}
-		})
-	}
-}
-
-func TestCompareDeployedBytecodeWithRpcFailures(t *testing.T) {
-	if err := configureGenerator(t); err != nil {
-		t.Error(err)
-	}
-
-	for _, tt := range compareDeployedBytecodeWithRpcTestsFailures {
-		t.Run(tt.name, func(t *testing.T) {
-			err := generator.CompareDeployedBytecodeWithRpc(&tt.contractMetadataEth, tt.chain)
-			if err == nil {
-				t.Errorf("Expected error: %s but didn't receive it", tt.expectedError)
-				return
-			}
-
-			if !strings.Contains(err.Error(), tt.expectedError) {
-				t.Errorf("Expected error: %s Received: %s", tt.expectedError, err)
-				return
-			}
-		})
-	}
-}

packages/contracts-bedrock/package.json

@@ -10,10 +10,6 @@
     "src/**/*.sol"
   ],
   "scripts": {
-    "bindings": "pnpm bindings:ts && pnpm bindings:go",
-    "bindings:ts": "nx generate @eth-optimism/contracts-ts",
-    "bindings:go:no-build": "cd ../../op-bindings && make bindings-build",
-    "bindings:go": "pnpm clean && pnpm build && pnpm bindings:go:no-build",
     "prebuild": "./scripts/checks/check-foundry-install.sh",
     "build": "forge build",
     "build:go-ffi": "(cd scripts/go-ffi && go build)",
@@ -34,7 +30,7 @@
     "validate-spacers:no-build": "npx tsx scripts/checks/check-spacers.ts",
     "validate-spacers": "pnpm build && pnpm validate-spacers:no-build",
     "clean": "rm -rf ./artifacts ./forge-artifacts ./cache ./tsconfig.tsbuildinfo ./tsconfig.build.tsbuildinfo ./scripts/go-ffi/go-ffi ./.testdata ./deployments/hardhat/*",
-    "pre-pr:no-build": "pnpm gas-snapshot:no-build && pnpm snapshots && pnpm semver-lock && pnpm autogen:invariant-docs && pnpm lint && pnpm bindings:go:no-build",
+    "pre-pr:no-build": "pnpm gas-snapshot:no-build && pnpm snapshots && pnpm semver-lock && pnpm autogen:invariant-docs && pnpm lint",
     "pre-pr": "pnpm clean && pnpm build:go-ffi && pnpm build && pnpm pre-pr:no-build",
     "pre-pr:full": "pnpm test && pnpm validate-deploy-configs && pnpm validate-spacers && pnpm pre-pr",
     "lint:ts:check": "eslint . --max-warnings=0",