Commit c5c909aa authored by Mark Tyneway's avatar Mark Tyneway Committed by GitHub

Merge pull request #8406 from testinprod-io/tip/delta-override

Add Delta override flag
parents dc2d2099 e88956a9
...@@ -284,6 +284,12 @@ var ( ...@@ -284,6 +284,12 @@ var (
EnvVars: prefixEnvVars("OVERRIDE_CANYON"), EnvVars: prefixEnvVars("OVERRIDE_CANYON"),
Hidden: false, Hidden: false,
} }
DeltaOverrideFlag = &cli.Uint64Flag{
Name: "override.delta",
Usage: "Manually specify the Delta fork timestamp, overriding the bundled setting",
EnvVars: prefixEnvVars("OVERRIDE_DELTA"),
Hidden: false,
}
) )
var requiredFlags = []cli.Flag{ var requiredFlags = []cli.Flag{
...@@ -332,6 +338,7 @@ var optionalFlags = []cli.Flag{ ...@@ -332,6 +338,7 @@ var optionalFlags = []cli.Flag{
RollupLoadProtocolVersions, RollupLoadProtocolVersions,
CanyonOverrideFlag, CanyonOverrideFlag,
L1RethDBPath, L1RethDBPath,
DeltaOverrideFlag,
} }
// Flags contains the list of configuration options available to the binary. // Flags contains the list of configuration options available to the binary.
......
...@@ -203,16 +203,12 @@ Startup will proceed to use the network-parameter and ignore the rollup config. ...@@ -203,16 +203,12 @@ Startup will proceed to use the network-parameter and ignore the rollup config.
Conflicting configuration is deprecated, and will stop the op-node from starting in the future. Conflicting configuration is deprecated, and will stop the op-node from starting in the future.
`, "network", network, "rollup_config", rollupConfigPath) `, "network", network, "rollup_config", rollupConfigPath)
} }
config, err := chaincfg.GetRollupConfig(network) rollupConfig, err := chaincfg.GetRollupConfig(network)
if err != nil { if err != nil {
return nil, err return nil, err
} }
if ctx.IsSet(flags.CanyonOverrideFlag.Name) { applyOverrides(ctx, rollupConfig)
canyon := ctx.Uint64(flags.CanyonOverrideFlag.Name) return rollupConfig, nil
config.CanyonTime = &canyon
}
return config, nil
} }
file, err := os.Open(rollupConfigPath) file, err := os.Open(rollupConfigPath)
...@@ -225,11 +221,19 @@ Conflicting configuration is deprecated, and will stop the op-node from starting ...@@ -225,11 +221,19 @@ Conflicting configuration is deprecated, and will stop the op-node from starting
if err := json.NewDecoder(file).Decode(&rollupConfig); err != nil { if err := json.NewDecoder(file).Decode(&rollupConfig); err != nil {
return nil, fmt.Errorf("failed to decode rollup config: %w", err) return nil, fmt.Errorf("failed to decode rollup config: %w", err)
} }
applyOverrides(ctx, &rollupConfig)
return &rollupConfig, nil
}
func applyOverrides(ctx *cli.Context, rollupConfig *rollup.Config) {
if ctx.IsSet(flags.CanyonOverrideFlag.Name) { if ctx.IsSet(flags.CanyonOverrideFlag.Name) {
canyon := ctx.Uint64(flags.CanyonOverrideFlag.Name) canyon := ctx.Uint64(flags.CanyonOverrideFlag.Name)
rollupConfig.CanyonTime = &canyon rollupConfig.CanyonTime = &canyon
} }
return &rollupConfig, nil if ctx.IsSet(flags.DeltaOverrideFlag.Name) {
delta := ctx.Uint64(flags.DeltaOverrideFlag.Name)
rollupConfig.DeltaTime = &delta
}
} }
func NewSnapshotLogger(ctx *cli.Context) (log.Logger, error) { func NewSnapshotLogger(ctx *cli.Context) (log.Logger, error) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment