Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
cf02d753
Unverified
Commit
cf02d753
authored
Mar 03, 2023
by
mergify[bot]
Committed by
GitHub
Mar 03, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #5042 from ethereum-optimism/willc/allowfailures
fix(atst): Allow failures removal
parents
3e5416c6
a045e042
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
10 deletions
+5
-10
fluffy-geese-yell.md
.changeset/fluffy-geese-yell.md
+5
-0
sdk.md
packages/atst/docs/sdk.md
+0
-5
readAttestations.ts
packages/atst/src/lib/readAttestations.ts
+0
-4
AttestationReadParams.ts
packages/atst/src/types/AttestationReadParams.ts
+0
-1
No files found.
.changeset/fluffy-geese-yell.md
0 → 100644
View file @
cf02d753
---
'
@eth-optimism/atst'
:
minor
---
Remove broken allowFailures as option
packages/atst/docs/sdk.md
View file @
cf02d753
...
...
@@ -171,11 +171,6 @@ const attestation = await readAttestations({
* @defaults defaults to the create2 address
*/
contractAddress
,
/**
* Boolean: Whether to allow some of the calls to fail
* Defaults to false
*/
allowFailures
,
})
```
...
...
packages/atst/src/lib/readAttestations.ts
View file @
cf02d753
...
...
@@ -19,7 +19,6 @@ import { parseAttestationBytes } from './parseAttestationBytes'
* creator: creatorAddress,
* about: aboutAddress,
* key: 'my_key',
* allowFailure: false,
* },
* {
* creator: creatorAddress2,
...
...
@@ -27,7 +26,6 @@ import { parseAttestationBytes } from './parseAttestationBytes'
* key: 'my_key',
* dataType: 'number',
* contractAddress: '0x1234',
* allowFailure: false,
* },
* )
*/
...
...
@@ -40,7 +38,6 @@ export const readAttestations = async (
about
,
key
,
contractAddress
=
ATTESTATION_STATION_ADDRESS
,
allowFailure
=
false
,
}
=
attestation
if
(
key
.
length
>
32
)
{
throw
new
Error
(
...
...
@@ -52,7 +49,6 @@ export const readAttestations = async (
abi
,
functionName
:
'
attestations
'
,
args
:
[
creator
,
about
,
formatBytes32String
(
key
)
as
WagmiBytes
],
allowFailure
,
}
as
const
})
...
...
packages/atst/src/types/AttestationReadParams.ts
View file @
cf02d753
...
...
@@ -11,5 +11,4 @@ export interface AttestationReadParams {
key
:
string
dataType
?:
DataTypeOption
contractAddress
?:
Address
allowFailure
?:
boolean
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment