Merge pull request #5658 from ethereum-optimism/clabby/sdk/migrated-withdrawal-gas

feat(sdk): Update `message-utils` to mimic `MigrateWithdrawalGasLimit`

packages/sdk/src/utils/message-utils.ts

@@ -5,6 +5,15 @@ import { LowLevelMessage } from '../interfaces'
 
 const { hexDataLength } = utils
 
+// Constants used by `CrossDomainMessenger.baseGas`
+const RELAY_CONSTANT_OVERHEAD = BigNumber.from(200_000)
+const RELAY_PER_BYTE_DATA_COST = BigNumber.from(16)
+const MIN_GAS_DYNAMIC_OVERHEAD_NUMERATOR = BigNumber.from(64)
+const MIN_GAS_DYNAMIC_OVERHEAD_DENOMINATOR = BigNumber.from(63)
+const RELAY_CALL_OVERHEAD = BigNumber.from(40_000)
+const RELAY_RESERVED_GAS = BigNumber.from(40_000)
+const RELAY_GAS_CHECK_BUFFER = BigNumber.from(5_000)
+
 /**
  * Utility for hashing a LowLevelMessage object.
  *
@@ -46,11 +55,35 @@ export const migratedWithdrawalGasLimit = (
   chainID: number
 ): BigNumber => {
   // Compute the gas limit and cap at 25 million
-  const dataCost = BigNumber.from(hexDataLength(data)).mul(16)
-  let overhead = 200_000
-  if (chainID !== 420) {
-    overhead = 1_000_000
+  const dataCost = BigNumber.from(hexDataLength(data)).mul(
+    RELAY_PER_BYTE_DATA_COST
+  )
+  let overhead: BigNumber
+  if (chainID === 420) {
+    overhead = BigNumber.from(200_000)
+  } else {
+    // Dynamic overhead (EIP-150)
+    // We use a constant 1 million gas limit due to the overhead of simulating all migrated withdrawal
+    // transactions during the migration. This is a conservative estimate, and if a withdrawal
+    // uses more than the minimum gas limit, it will fail and need to be replayed with a higher
+    // gas limit.
+    const dynamicOverhead = MIN_GAS_DYNAMIC_OVERHEAD_NUMERATOR.mul(
+      1_000_000
+    ).div(MIN_GAS_DYNAMIC_OVERHEAD_DENOMINATOR)
+
+    // Constant overhead
+    overhead = RELAY_CONSTANT_OVERHEAD.add(dynamicOverhead)
+      .add(RELAY_CALL_OVERHEAD)
+      // Gas reserved for the worst-case cost of 3/5 of the `CALL` opcode's dynamic gas
+      // factors. (Conservative)
+      // Relay reserved gas (to ensure execution of `relayMessage` completes after the
+      // subcontext finishes executing) (Conservative)
+      .add(RELAY_RESERVED_GAS)
+      // Gas reserved for the execution between the `hasMinGas` check and the `CALL`
+      // opcode. (Conservative)
+      .add(RELAY_GAS_CHECK_BUFFER)
   }
+
   let minGasLimit = dataCost.add(overhead)
   if (minGasLimit.gt(25_000_000)) {
     minGasLimit = BigNumber.from(25_000_000)