Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
d205c1d6
Unverified
Commit
d205c1d6
authored
Nov 24, 2021
by
Conner Fromknecht
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
feat: surface single tx execution errors in commitTransactionsWithError
parent
a291745d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
0 deletions
+20
-0
angry-ducks-arrive.md
.changeset/angry-ducks-arrive.md
+5
-0
worker.go
l2geth/miner/worker.go
+14
-0
worker_test.go
l2geth/miner/worker_test.go
+1
-0
No files found.
.changeset/angry-ducks-arrive.md
0 → 100644
View file @
d205c1d6
---
'
@eth-optimism/l2geth'
:
patch
---
surface sequencer low-level sequencer execution errors
l2geth/miner/worker.go
View file @
d205c1d6
...
...
@@ -879,6 +879,20 @@ func (w *worker) commitTransactionsWithError(txs *types.TransactionsByPriceAndNo
log
.
Debug
(
"Transaction failed, account skipped"
,
"hash"
,
tx
.
Hash
(),
"err"
,
err
)
txs
.
Shift
()
}
// UsingOVM
// Return specific execution errors directly to the user to
// avoid returning the generic ErrCannotCommitTxnErr. It is safe
// to return the error directly since l2geth only processes at
// most one transaction per block. Currently, we map
// ErrNonceTooHigh to ErrNonceTooLow to match the behavior of
// the mempool, but this mapping will be removed at a later
// point once we decided to expose ErrNonceTooHigh to users.
if
err
==
core
.
ErrNonceTooHigh
{
return
core
.
ErrNonceTooLow
}
else
if
err
!=
nil
{
return
err
}
}
if
!
w
.
isRunning
()
&&
len
(
coalescedLogs
)
>
0
{
...
...
l2geth/miner/worker_test.go
View file @
d205c1d6
...
...
@@ -197,6 +197,7 @@ func TestGenerateBlockAndImportEthash(t *testing.T) {
}
func
TestGenerateBlockAndImportClique
(
t
*
testing
.
T
)
{
t
.
Skip
(
"OVM breaks this since it aborts after first tx fails"
)
testGenerateBlockAndImport
(
t
,
true
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment